Lmms: Equalizer: The visualizer takes up most of the processing time of the plugin, regardless of whether or not the plugin is open

Created on 2 Jun 2018  路  3Comments  路  Source: LMMS/lmms

Tested on my current working branch (master from a week ago) with debugging symbols.

Steps to reproduce:
1) Add equalizers to the master channel until you see a significant cpu drop when you play a note.
2) Disable visualizers on all equalizers
3) Play a note, notice that the CPU is significantly lower.

With visualizers enabled:
image

Without visualizers enabled:
image

performance

Most helpful comment

I will correct this now.

All 3 comments

Currently EQ uses EqSpectrumView::paintEvent to enable/disable analyzing, but the event function won't be called if the window is closed.
I think it should use the visibility of EqControlsDialog. I will fix this.

I will correct this now.

Fixed via the PR above.

Was this page helpful?
0 / 5 - 0 ratings