Lmms: Different hotkey for pause and stop

[MrcSnm]

When playing on piano roll, there is an option on the tool bar to stop the current playing and to pause it.

The difference between them is that stop will go back to the 0:00 position, while pause will maintain the current track position, what I want is to correct a bug that Stop and Pause button have the same hotkey (Spacebar), and that is boring me to death, I don't want to be going back to 0 every time I press this key.

What I recommend is having Spacebar for Pause and Shift+Spacebar for Stop, I would program this myself, but I really don't know where is the controller for that.

There is a screenshot I made showing that the hotkey are the same for these two options

[tjrdnjs1609]

i try to solve this problem. but i couldn't find 'pause' in SongEditor.cpp . anyone who can explain about how to add or change 'pause' shortcut???

[zonkmachine]

Have a look at void SongEditorWindow::play()

[MrcSnm]

Please remember that this problem persists on piano roll, song editor and much probably in beat editor

[musikBear]

728 orr. post ..and from 2014...!

[tjrdnjs1609]

musikBear

728 orr. post ..and _from_ 2014...!

Thanks for the good info. but i think same shortcut is still problem.

Does it make sense if I solve this problem?

[MrcSnm]

Absolutely

musikBear

728 orr. post ..and _from_ 2014...!

Thanks for the good info. but i think same shortcut is still problem.

Does it make sense if I solve this problem?

Absolutely, having this bug on pause/stop really breaks the workflow

[zonkmachine]

Does it make sense if I solve this problem?

@tjrdnjs1609 As you have volunteered to fix this and have a PR open I have assigned you to this issue.

[russiankumar]

Hey, is this being worked on? The PR seems inactive and I'd be glad to work on this if I am allowed to.

[DomClark]

Fixed in #5554.