Lmms: Some problems with VST. Again.

[Andrew344]

VST preset files doesn’t appear in LMMS search window. But, in Windows file manager all is OK.
It occurs in LMMS 1.1.3 , 1.2.0 rc2, rc3. If I write file name in search line and press enter, the preset file will open successful. But, if I click button, it doesn't happen.

Howewer, after reloading LMMS project, even if project was saved with need preset, VST plugin settings still returns to primary preset.

[tresf]

Could a typo in the translation file cause this? (the comma?)

https://github.com/LMMS/lmms/blob/32f07ac317b42dda42a1d00b0a3b1fa1feef0655/data/locale/ru.ts#L7206

[Andrew344]

I change the language on English, and now files are visible.
At this moment, I do not checked the code on link , but anyway, VST plugin settings still returns to primary preset after reloading project.

[Andrew344]

Later, I will analyze it, and correct mistakes.
Thanks for help.

[musikBear]

Ahhh.. sounds like the 'umlaut' problem
ä, ö, ü, æ, ø, å
amo. -can be problems in filenames as well as foldernames

[tresf]

@musikBear do you have evidence of this problem? His folders do not contain the characters you mention, only the save dialog, which shouldn't affect it. My investigation points to a translation issue. You should be able to unit test this using the raw translation file and running it though Qt Linguist. Once that is done you or someone can work with @liushuyu to fix.

[oeai]

maybe because of this?

<message>
    <source>.fxp</source>
    <translation>.fxp</translation>
</message>
<message>
    <source>.FXP</source>
    <translation>.FXP</translation>
</message>
<message>
    <source>.FXB</source>
    <translation>.FXB</translation>
</message>
<message>
    <source>.fxb</source>
    <translation>.fxb</translation>

if it goes into a search pattern as a translation (since there is a translation), but it don't understand it, since there's no need in translation
i don't think that "," can bug the code, not sure when i can test \ recompile it
where to find that search pattern in code?

changed string 1709 to no-comma

[oeai]

i remember that there were the same problem with converting to ogg, when values for converting were taken from the selected string (that was also translated) and same problem happened in chinese.
what i propose is to change the code programing paradigm for example search_file_by_pattern function if there is any, so it was taken strict file extensions not from "(String_from_gui_defined_by_brackets)", but from defined by value massive "0value:string0;1value:string1" so it was independent of translations and user act, but only gui dropdown menu value changes
As a translator i don't see where exactly is string used and can't expect that translation can influence on code flow -> that cannot be happened

[DomClark]

The resetting of VST settings when the project is reloaded was probably fixed in #4401.
As for the missing preset files, @tresf seems to be correct; upon removing the comma, the files show up normally. The issue is present in the Russian and Ukrainian translations:
https://github.com/LMMS/lmms/blob/698c39d38525c45d47c4b5a708747b7ff0a007cb/data/locale/ru.ts#L7206
https://github.com/LMMS/lmms/blob/698c39d38525c45d47c4b5a708747b7ff0a007cb/data/locale/uk.ts#L7202
How do we get translations into 1.2 currently? Should this be fixed on Transifex or manually in a PR?

[zonkmachine]

How do we get translations into 1.2 currently? Should this be fixed on Transifex or manually in a PR?

Manual PR. Transifex is now pointing to master. Maybe the parenthesis (*.fxp *.fxb) shouldn't be translatable at all.

[zonkmachine]

https://github.com/LMMS/lmms/blob/f37ca49e6d52886d40858e23acd1d3ed32f97a71/plugins/vst_base/VstPlugin.cpp#L424

Maybe change that to something like tr( "Vst Plugin Preset" ) + " (*.fxp *.fxb)" );
Are there cases where suffixes actually need to be translatable?