Lizmap-web-client: popup tool - mobile mode (edition)

[josemvm]

hi

on mobile devices, when a user tries to edit a feature from popup window, the edition tool panel doesn't appear, then the user must press the edition icon on the vertical toolbox bar.

lwc: 3.2 and master
qgis server: all

thanks

[josemvm]

on lwc 3.1.5 it's ok

[nboisteault]

Confirmed. Issue appears when window width is inferior to 900 px.

[nboisteault]

@rldhont here if we are in mobile mode and the dock is visible, we click so it closes the tool window. Is it voluntary because we think user could modify the geometry first then edit attribute data ?

If user just want to modify attribute data it is annoying.
On the other hand if he wants to modify the geometry, he will have to close the window, modify the geom, then open the window to save.
I think it is more likely users change attribute data than geometry.
It seems it is an UX problem.

[rldhont]

@nboisteault @josemvm I do not know if the modification of the attributes has priority over the modification of the geometry.
It's an UX problem and probably needs to be configurable.

[josemvm]

i think that the modification of the attributes is more frequent than the modification of the geometry...

[rldhont]

@nboisteault can you propose the changes ?

[nboisteault]

1. We could propose a layer option in plugin to let the user choose what he wants to edit first, geometry or attribute data.
2. We could differentiate actions with two buttons that give priority to geometry or attribute data edition
3. one activate geometry edition and display a 'save' button to quickly save without need to go in edition tab
4. the other one display attribute data form like today.

[josemvm]

i'm for the second option

[nboisteault]

@rldhont @mdouchin Do you have any other suggestions than those in my last comment. If not, what do you prefer ?

[josemvm]

i think it is necessary to take a decision on this issue...
thanks

[mdouchin]

I think we should not add a button. IMHO, in mobile mode, we should

• For insert, 1st let the user add the geometry. Then open the form when geometry has been added
• For updates, do the opposite, ie show the form first. The user would be able to hide it if he needs to edit the geometry.

[3liz-bot]

Hiya!
This issue has gone quiet. 👻
We get a few questions in the bug tracker, so we currently slowly closing issues.
If we missed this issue or if you want to keep it open, please reply here.
As a friendly reminder: the best way to see this issue, or any other, fixed is to open a Pull Request.
Thanks for being a part of the Lizmap community! 🦎

[nboisteault]

I don't think we'll fix this as 3.3 branch is end-of-life, we don't have any test for it and I don't want to introduce any other regression.