Live-share: Keep being signed out of GitHub

[AmirGamilDev]

Issue Type: Bug

I find that closing and re-opening VS Code means that I'm signed out of GitHub each time when I attempt to start or join a collaboration session. This didn't used to happen. I'm not sure if this is due to an update to VS Code or something else.

Extension version: 1.0.2274
VS Code version: Code 1.45.1 (5763d909d5f12fe19f215cbfdd29a91c0fa9208a, 2020-05-14T08:27:35.169Z)
OS version: Windows_NT x64 10.0.18362

System Info

|Item|Value|
|---|---|
|CPUs|AMD Ryzen 7 2700U with Radeon Vega Mobile Gfx (8 x 2196)|
|GPU Status|2d_canvas: enabled
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
oop_rasterization: disabled_off
protected_video_decode: unavailable_off
rasterization: enabled
skia_renderer: disabled_off_ok
video_decode: enabled
viz_display_compositor: enabled_on
viz_hit_test_surface_layer: disabled_off_ok
webgl: enabled
webgl2: enabled|
|Load (avg)|undefined|
|Memory (System)|6.90GB (1.35GB free)|
|Process Argv||
|Screen Reader|no|
|VM|0%|

[setaskin]

thank you for reaching out. As a workaround, can you try running this command: Live Share: Disable VSCode account authentication? This will revert the authentication to the old flow. Please let us know if this unblocks you.

[setaskin]

if it still doesn't work, your logs may provide us with helpful information. You can access them via the Live Share: Export Logs command from the command palette (ctrl + shift + p) and attach them to this issue.

[AmirGamilDev]

Hi. Thanks for the response.

thank you for reaching out. As a workaround, can you try running this command: Live Share: Disable VSCode account authentication? This will revert the authentication to the old flow. Please let us know if this unblocks you.

I tried this but no joy. It did the change the flow but the same issue persists (not signed in from session to session).

If it helps, I was experimenting with a Live Share in Visual Studio 2019 and I _think_ I tried doing a Live Share between Visual Studio 2019 and VS Code on the same machine (and same account) to see if it would work. The problem appeared shortly after. Not sure if they are related but thought it worth mentioning.

if it still doesn't work, your logs may provide us with helpful information. You can access them via the Live Share: Export Logs command from the command palette (ctrl + shift + p) and attach them to this issue.

I'm happy to do this. Can you let me know if there would be any sensitive info/PII in these logs? If so, can you point me to them so that I can remove them before attaching? Thanks.

[NobleAscent]

thank you for reaching out. As a workaround, can you try running this command: Live Share: Disable VSCode account authentication? This will revert the authentication to the old flow. Please let us know if this unblocks you.

This fixed the problem for me. 👍

[setaskin]

@AmirGamilDev , we try to keep the logs free of PII, but please double check before you post here, and if you find any, let us know so that we can remove it. If you are still not comfortable to posting it , you can send to us via : [email protected]. Please add this issue number to the e-mail, so we correlate your logs with the issue.

[AmirGamilDev]

@AmirGamilDev , we try to keep the logs free of PII, but please double check before you post here, and if you find any, let us know so that we can remove it. If you are still not comfortable to posting it , you can send to us via : [email protected]. Please add this issue number to the e-mail, so we correlate your logs with the issue.

I took a look through the logs and am _fairly_ satisfied that there's no PII. I shall still send it via email though.

[jonathan-fielding]

Myself and my colleagues all have this issue and I was wondering could it be due to our GitHub accounts also having SSO enabled for our org repos, will try your suggested fix tho

[AmirGamilDev]

Hi folks @setaskin

Just letting you know that I noticed today that this issue seems to be resolved. Not sure when it was resolved but it's working today in version 1.0.3014 of the Live Share extension.

Thanks to whoever fixed it! 👍 ❤️

Live Share version:
1.0.3014

VS Code
Version: 1.50.1 (user setup)
Commit: d2e414d9e4239a252d1ab117bd7067f125afd80a
Date: 2020-10-13T15:06:15.712Z
Electron: 9.2.1
Chrome: 83.0.4103.122
Node.js: 12.14.1
V8: 8.3.110.13-electron.0
OS: Windows_NT x64 10.0.18362

[BrunoGuardia]

Thanks for the update! @dlebu made a fix a few weeks ago but seems we missed updating this one.

Will resolve, feel free to reopen if anybody is still seeing this specific issue.

[AmirGamilDev]

Thanks @dlebu for the fix 👍 and you're welcome @BrunoGuardia