Issue Type: Bug
Oauth fails with unsupported redirect domain when using github
Extension version: 1.0.1653
VS Code version: VSCodium 1.41.1 (26076a4de974ead31f97692a0d32f90d735645c0, 2019-12-19T20:28:43.121Z)
OS version: Linux x64 5.3.0-28-generic
System Info
|Item|Value|
|---|---|
|CPUs|Intel(R) Core(TM) i5-3570 CPU @ 3.40GHz (4 x 3602)|
|GPU Status|2d_canvas: enabled
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
metal: disabled_off
multiple_raster_threads: enabled_on
oop_rasterization: disabled_off
protected_video_decode: unavailable_off
rasterization: disabled_software
skia_renderer: disabled_off
surface_control: disabled_off
surface_synchronization: enabled_on
video_decode: unavailable_off
viz_display_compositor: enabled_on
viz_hit_test_surface_layer: disabled_off
webgl: enabled
webgl2: enabled|
|Load (avg)|5, 4, 2|
|Memory (System)|7.72GB (0.17GB free)|
|Process Argv|--no-sandbox --unity-launch|
|Screen Reader|no|
|VM|0%|
Can you please provide more information about the scenario when you hit the issue? Also can you provide us your logs too? You can access them via the Live Share: Export Logs command from the command palette (ctrl + shift + p) and attach them to this issue.
Issue with https://github.com/VSCodium/vscodium.git; probably stripped too much.
Microsoft version of VSCode works.
You can still get it to work in VSCodium by using the code - not the one from the URL!
You can still get it to work in VSCodium by using the code - not the one from the URL!
Initiate login with VS Code - the Microsoft build
No need to download it - just go to https://insiders.liveshare.vsengsaas.visualstudio.com/auth/login and generate your user code there.
From VSCode, Live Share opens this link in the browser:
https://prod.liveshare.vsengsaas.visualstudio.com/auth/identity/github/?redirect=vscode://ms-vsliveshare.vsliveshare/signin%253FwindowId=1&state=…&extensionId=…&nonce=…
But from VSCodium, this link is opened:
https://prod.liveshare.vsengsaas.visualstudio.com/auth/identity/github/?redirect=vscodium://ms-vsliveshare.vsliveshare/signin%253FwindowId=1&state=…&extensionId=…&nonce=…
Notice the different protocol here: vscodium instead of vscode. So looks like Live Share now checks if the redirect URL is “valid” and rejects what it considers to be “invalid”, especially given that authorization used to work under VSCodium and still works if you install an older version of Live Share.
Most helpful comment
No need to download it - just go to https://insiders.liveshare.vsengsaas.visualstudio.com/auth/login and generate your user code there.