Live-share: Debug cannot read property 'onError' of undefined

[carlocardella]

Product and Version [VS/VSCode]: VSCode
OS Version [macOS/Windows]: Windows

Version: 1.29.0-insider (user setup)
Commit: 4626bc0e1b679d555dd6f034ece35ffc394b3bb7
Date: 2018-10-29T06:18:55.850Z
Electron: 2.0.12
Chrome: 61.0.3163.100
Node.js: 8.9.3
V8: 6.1.534.41
Architecture: x64

Live Share Extension Version: 0.3.869

Steps to Reproduce / Scenario:

1. Open a ps1 file in VSCode
2. Start debugging (F5)
3. See error
   

I reported it to the Powershell extension (#1590) and VSCode (#61649).

The error disappears if I disable Live Share.
_Note:_ I cannot reproduce the error on VSCode Stable and on a Dell XPS laptop using VSCode Insiders (same version and extensions as the two failing machines).

I have found #58847 but the issue is closed.
Also, the error is similar to #970 but in my case I am not attempting to use Live Share, I just want to debug locally.

LiveShareExportLogs.zip

[Moniarchy]

Thanks for reporting this. Adding @jramsay.

[carlocardella]

Adding @tylerl0706 FYI

[fromthewoods]

I am getting this same error on the stable version:

Version: 1.30.0 (user setup)
Commit: c6e592b2b5770e40a98cb9c2715a8ef89aec3d74
Date: 2018-12-11T22:29:11.253Z
Electron: 2.0.12
Chrome: 61.0.3163.100
Node.js: 8.9.3
V8: 6.1.534.41
OS: Windows_NT x64 10.0.17134

If I disable the VS Live Share extension, the problem goes away.

[carlocardella]

I got this yesterday on the latest Stable

[ytugarev]

Same here

[jramsay]

@carlocardella : I'm able to repro this issue - thanks for filing!

@isidorn, @weinand: _VS Live Share_ has now switched to using the DA tracker API. As per Andre's comments on another issue:

But when a Tracker is installed, we are running the DA inside the extension host (instead of inside VS Code).

The issue is that with LiveShare the DA is launched from the ExtensionHost instead of being launched from VS Code (which is expected and correct).

I've confirmed that by setting debug.extensionHostDebugAdapter to true the problem reproduces without LiveShare being installed.

Should we reopen the VS Code issue with this new info for further investigation?
https://github.com/Microsoft/vscode/issues/61649

[jramsay]

The fix for this issue was made in VS Code and will be available in an upcoming VS Code release:
https://github.com/Microsoft/vscode/issues/61649