Live-share: OS X El Capitan displays wrong OS version number in error message

[codycraven]

Live Share requires MacOS Sierra or better (due to .NET Core 2.0). The error message in VSCode under OS X El Capitan is confusing because an error message displayed (when on El Capitan) cites the wrong version of the OS.

Product and Version [VS/VSCode]: VSCode 1.21.1
OS Version [macOS/Windows]: MacOS 10.11.6
Live Share Extension Version: 0.2.163
Target Platform or Language [e.g. Node.js]: N/A

Steps to Reproduce / Scenario:

1. Have OS X El Capitan as operating system
2. Install VS Live Share extension in VSCode
3. Witness error notification stating "Your version of MacOS (incorrect version number here) is not compatible with this version of Visual Studio Live Share.

[Chuxel]

@codycraven Thanks for letting us know! Not quite sure where the version number in that message is coming from actually. 🤔 We'll take a look.

[davidkpiano]

The version number is what is returned directly from os.release().

[Chuxel]

@davidkpiano That gives the kernel version for macOS which isn't something users typically know. That would explain it. (It uses uname.) "15" is the major version for El Capitan's kernel. We can log that in the log output, but for a customer facing message stating El Capitan (10.11) and below is not supported would be the right thing to do. Ditto for Windows/Linux.

[Chuxel]

This one was resolved in 0.2.399.

[Haddassah]

How was this resolved? I am getting this error.

[Chuxel]

@Haddassah El Capitan is not supported, but the version number in the message was corrected. If the error message is still wrong, it might have regressed.