Lint-staged: Lint-staged but to lint modified files from a pull request ?

[clakech]

Hi,

I would like to get your feedback about a new tool / enhancement to lint-staged to lint modified files
from a pull request at build time.

Would you love it ?

What are your ideas to reuse the code from lint-staged to do it ?

WDYT ?

[luftywiranda13]

I kinda like this idea

But is there any specific task you need to run?
I mean for ESLint, we can run eslint . --cache for jest there is jest --lastCommit

[clakech]

Yes, We may not be able to use --cache if build environnement is run on another node/agent ?

[luftywiranda13]

CMIIW I think ESLint reads from .eslintcache, so as long as we commit it in our repo ESLint will be able to check only modified files

[clakech]

@luftywiranda13 nice idea, is it a good practice to commit the eslint cache files ?

[clakech]

@luftywiranda13 BTW can we 'trust' a eslint cache file updated in a PR ? no malicious way to bypass the linter ?

[okonet]

Is this similar to #150?

[luftywiranda13]

@okonet I think @clakech wants to make a GitHub app with a bot which will get triggered when someone open a PR

[luftywiranda13]

Sorry, accidentally closed this. Fat fingers :s

[clakech]

@okonet nope I think this is a different use case. #150 is for current local unstaged files. This question is for "every single files modified in the current pull request that cas contains several commits". But yes, this can be out of scope of this lib. I am just getting feedback to find a path to a good solution ;)

[luftywiranda13]

For ESLint specifically, I personally against the idea of using --cache flag on ESLint to make sure the whole codebase get checked if the eslint config or eslint itself get updated

[clakech]

my use case is a legacy project with A LOT of eslint errors / warning and we may need to apply lint config only on new / modified files

[okonet]

Well, if we can ditch staged-git-files or make the first step pluggable this will be possible. I'm open for explorations since it might open interesting opportunities.

[okonet]

@clakech in this case the simplest way to do so is just to have separate .eslintrc in different directories. I have the same use case and it's totally covered by eslint.

[clakech]

I have a committed-git-files module now, forked from staged-git-files. I forked lint-staged too and plug this new module and tada now I got what I wanted.
I may contribute back this once I figure out how to insert my code elegantly.

[clakech]

commited-git-files could be a optional dependency of lint-staged and we could use a npm script:
lint-staged --target-branch origin/master

[clakech]

source is here: https://www.npmjs.com/package/lint-committed