Lint-staged: Fix lack of emoji support on Windows

Created on 4 Sep 2017  路  10Comments  路  Source: okonet/lint-staged

Emoji isn't supported on windows cmd

like this line
https://github.com/okonet/lint-staged/blob/d99eb3815cbcb7f76d0adf693fe4017c8e31cf7c/src/runScript.js#L50

and this line
https://github.com/okonet/lint-staged/blob/d99eb3815cbcb7f76d0adf693fe4017c8e31cf7c/src/runScript.js#L54

So I'm thinking about using log-symbols to replace those emojis. What do you guys think? any opinions?

Windows enhancement

Most helpful comment

+1 from me!

All 10 comments

I like it. But wouldn't this be better - https://github.com/sindresorhus/figures?

That's great! I was thinking of replacing them with symbols.

I like the https://github.com/sindresorhus/log-symbols more since it's more focused for the job.

What about Listr? Does it have required fallbacks?

I prefer log-symbols, because it's not bloated and hmmm has colors 馃槅

What about Listr? Does it have required fallbacks?

yeah, Listr uses log-symbols

I think it's even better to utilize https://github.com/SamVerschueren/listr#promises, ain't it?

@luftywiranda13 in what context? Not sure how it's related to symbols...

We are utilizing it already. runScript returns a promise.

ah yeah, how could I miss that 馃槅

so... is it worth to try if I make a PR to integrate log-symbols?

+1 from me!

Was this page helpful?
0 / 5 - 0 ratings