Linkerd2: Emit Proxy Spans

Created on 2 Aug 2019  路  6Comments  路  Source: linkerd/linkerd2

What problem are you trying to solve?

When viewing distributed traces, it is beneficial to see the spans associated with proxies alongside those emitted by applications. This allows users to understand what overhead proxies are adding to their applications.

As this feature has serious performance implications and requires application changes to be useful, it must be configurable and disabled by default.

How should the problem be solved?

Out of scope

  • Installing and configuring the OpenTelemetry service.
  • Exporting any metadata outside of timing.
rfc

Most helpful comment

Implemented.

All 6 comments

Related to #1436.

It's worth noting that OpenCensus does not use the Trace-Context propagation format for gRPC requests. Instead, it uses a header called grpc-trace-bin: https://github.com/census-instrumentation/opencensus-specs/blob/master/trace/gRPC.md

This means that Linkerd must also read this header if it wishes to participate in gRPC traces.

If installing and configuring the OpenTelemetry service is out of scope, it becomes more difficult to send traces to the agent over TLS. The agent's trust root would need to be mounted into the proxy's container and thus the configuration gets a bit more complex.

If installing and configuring the OpenTelemetry service is out of scope, it becomes more difficult to send traces to the agent over TLS. The agent's trust root would need to be mounted into the proxy's container and thus the configuration gets a bit more complex.

it probably means we aught to have the proxy support the environment variables needed to read a trust root from disk; and leave it as an exercise to the user to get that mounted in the proxy's container...

image

Given a trace like the above, how should this change when the proxy is participating in tracing? @grampelberg

Implemented.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

vikas027 picture vikas027  路  4Comments

olix0r picture olix0r  路  3Comments

steve-fraser picture steve-fraser  路  4Comments

zaharidichev picture zaharidichev  路  4Comments

adleong picture adleong  路  4Comments