Linkerd2: Typo in check error message

Created on 23 Dec 2020  路  4Comments  路  Source: linkerd/linkerd2

This check validates that certOldKeyName is present in the secret. However, if it is not, the error message incorrectly refers to the certKeyName field. This error message should be corrected.

https://github.com/linkerd/linkerd2/blob/main/pkg/healthcheck/healthcheck.go#L1734

arecli good first issue help wanted
Source
picture adleong

All 4 comments

This was first noticed in https://github.com/linkerd/linkerd2/issues/5423

adleong picture adleong on 23 Dec 2020
👍1

I'd like to work on this issue.

pradeepnnv picture pradeepnnv on 24 Dec 2020

@pradeepnnv go for it! :+1: :partying_face:

alpeb picture alpeb on 28 Dec 2020
👍1

Thanks @alpeb . I submitted a PR. Please review.

pradeepnnv picture pradeepnnv on 28 Dec 2020
Was this page helpful?
0 / 5 - 0 ratings

Related issues

tustvold picture tustvold  路  4Comments
ihcsim picture ihcsim  路  4Comments
miklezzzz picture miklezzzz  路  3Comments
vikas027 picture vikas027  路  4Comments
briansmith picture briansmith  路  4Comments