Liipimaginebundle: Cache resolution fails if file name contains a plus (+)

[sujayjaju]

Preconditions

1. LiipImagineBundle 2.1
2. PHP 7.2

Steps to reproduce

1. Try resolving a file named "test+file.jpg". Eg:
   {{ "uploads/test+file.jpg" | imagine_filter('thumb') }}

Expected result

• Resolved image

Actual result

• Error" Source image for path "uploads/test file.jpg" could not be found

[sujayjaju]

Same issue if there is a hash (#) in the file name

[robfrawley]

A hash has a special context in a browser; same with a plus. You would need to encode the URL path for it to work properly.

[sujayjaju]

@robfrawley
Yes, but the problem is that the imagine_filter double encodes the file name, if the encoded name is passed to the filter. The solution that worked was to extract just the file name from the url returned by the filter and replaced it with the encoded version. That seems like quite a convoluted solution. Should the filter handle those cases?

[dbalabka]

@sujayjaju I have the same issue. The problem is that \Liip\ImagineBundle\Imagine\Cache\Resolver\ResolverInterface::resolve method implementations (WebPathResolver and probably others) do not expect that file system path might contain special characters. In case of URL, most of these characters should be encoded.

Probably the proper fix will be to convert filesystem path to URL path inside resolve() method implemenations in following way:

implode('/', array_map('rawurlencode', explode('/', $path)))

[andyexeter]

I can confirm @torinaki's solution fixes this issue. Care to submit a PR for this?

[dbalabka]

@anderageru, @sujayjaju PR is created

[dbalabka]

Fixed in #1162