Lighthouse-ci: Add SPA support to fallback server

Created on 17 Dec 2019  路  4Comments  路  Source: GoogleChrome/lighthouse-ci

the fallback-server does not support front-end router right now.

P2 enhancement good first issue

Most helpful comment

Working on it! n.n/

All 4 comments

Thanks for filing @lili21, good idea!

This should be fairly straightforward if anyone is looking for their first contribution :)

Basically add

app.get('*', (_, res) => res.sendFile(path.join(pathToBuildDir, 'index.html')))

to
https://github.com/GoogleChrome/lighthouse-ci/blob/3a34a7b0a9f57b78ec1d5c1be5263262408c61fa/packages/cli/src/collect/fallback-server.js#L18-L24

and a test to go along with it

Working on it! n.n/

I found this Issue after making pull request: https://github.com/GoogleChrome/lighthouse-ci/pull/159

@Amagon96 How is the progress? If you haven't started yet, I'd be happy to get feedback on this code.

Thanks.

Hi @rdlabo I think that is ok with your changes since it solves this issue, however I've check your changes and leave you a comment there, and you should use the closes #issueNumber, check it out ;)

Was this page helpful?
0 / 5 - 0 ratings

Related issues

WebCloud picture WebCloud  路  4Comments

PaulKujawa picture PaulKujawa  路  4Comments

xavierfoucrier picture xavierfoucrier  路  4Comments

mauriciabad picture mauriciabad  路  4Comments

WillsB3 picture WillsB3  路  5Comments