Lightgallery: Error when closing gallery

Created on 24 Dec 2018 · 17Comments · Source: sachinchoolur/lightGallery

In Chrome 71, exception is thrown when invoking document.exitFullscreen() while not in full-screen mode.
https://github.com/jpilfold/ngx-image-viewer/issues/23#issuecomment-446899261

Source

OXAYAZA

👍1

Most helpful comment

I have fixed this issue by editing the lightgallery-all.js file changing line 1645
From : if (document.exitFullscreen) {
To: if (document.fullscreenElement) {

stevepcooke on 30 Jan 2019

👍5

All 17 comments

I can confirm. Exact same bug.

sanastasiou on 29 Dec 2018

Will fix it locally with one of the mentioned workarounds.

sanastasiou on 30 Dec 2018

Same here. Any plans to fix this? :)

alexanderjakob on 9 Jan 2019

@sachinchoolur It looks like https://github.com/jpilfold/ngx-image-viewer/issues/23 had some potential fixes for this issue.

zslabs on 17 Jan 2019

Same here.

stat1x on 24 Jan 2019

Same here

moncero on 28 Jan 2019

I get this error sent to the DOM when closing the full screen view in Chrome

Uncaught (in promise) TypeError: Document not active
at Fullscreen.exitFullscreen
(lg-fullscreen.js:75)
at Fullscreen.destroy (lg-fullscreen.js:107)
at Function. (lightgallery.js:1311)
at Function.each (jquery-3.1.1.min.js:2)
at Plugin.destroy (lightgallery.js:1309)
at HTMLSpanElement. (lightgallery.js:1244)
at HTMLSpanElement.dispatch (jquery-3.1.1.min.js:3)
at HTMLSpanElement.q.handle (jquery-3.1.1.min.js:3)

Using your demo link [http://sachinchoolur.github.io/lightGallery/]
screen

stevepcooke on 30 Jan 2019

I have fixed this issue by editing the lightgallery-all.js file changing line 1645
From : if (document.exitFullscreen) {
To: if (document.fullscreenElement) {

stevepcooke on 30 Jan 2019

👍5

Fixing this problem in source files seems not to be the right solution

alexanderjakob on 31 Jan 2019

Same here.

hugolantaume on 7 Feb 2019

If someone can create a PR with the fix; this can most likely get fixed a lot sooner.

zslabs on 7 Feb 2019

Same here

elemis on 13 Feb 2019

mafh on 17 Feb 2019

Guys, Really sorry for the delayed response. The issue has been fixed.

sachinchoolur on 19 Feb 2019

👍4

Guys, Really sorry for the delayed response. The issue has been fixed.

Do not forget to add lib to NPM

screen shot 2019-02-19 at 5 26 01 pm

yoldar on 19 Feb 2019

👀3

+1

It seems like the error still occurs if we use the all.min.js from dist/js.

sanket-webmavens on 22 Nov 2019

You can open the all.min.js and search for prototype.exitFullscreen=function
and then change the {document.exitFullscreen?
to {document.fullscreenElement?

That fixes it.