Libgit2sharp: Expose Diff Hunks in API

Created on 8 Jul 2015 · 6Comments · Source: libgit2/libgit2sharp

Rather than doing string parsing, I'd prefer having diff hunks available to mess with.

Source

Therzok

👍3

Most helpful comment

@Therzok, I was wondering if ContentChanges, rather than PatchEntryChanges, could be a more convenient place.

I would try extending the HunkCallback, or LineCallBack: they receive the GitDiffHunk which already contains the line indexes:

    internal class GitDiffHunk
    {
        public int OldStart;
        public int OldLines;
        public int NewStart;
        public int NewLines;
        public UIntPtr HeaderLen;

        [MarshalAs(UnmanagedType.ByValArray, SizeConst = 128)]
        public byte[] Header;
}

So far, they only append the patch chunk to the string builder, and increment LinesAdded and LinesDeleted. They could also append the chunk beginning and ending line to a collection.

arialdomartini on 3 Nov 2018

👍3

All 6 comments

cc @nulltoken

Should we expose the hunks themselves together with the text patch? Inside PatchEntryChanges or something similar?

Therzok on 10 Jul 2015

👍1

@Therzok, I was wondering if ContentChanges, rather than PatchEntryChanges, could be a more convenient place.

I would try extending the HunkCallback, or LineCallBack: they receive the GitDiffHunk which already contains the line indexes:

    internal class GitDiffHunk
    {
        public int OldStart;
        public int OldLines;
        public int NewStart;
        public int NewLines;
        public UIntPtr HeaderLen;

        [MarshalAs(UnmanagedType.ByValArray, SizeConst = 128)]
        public byte[] Header;
}

So far, they only append the patch chunk to the string builder, and increment LinesAdded and LinesDeleted. They could also append the chunk beginning and ending line to a collection.

arialdomartini on 3 Nov 2018

👍3

Sounds good to me!

Therzok on 3 Nov 2018

👍2

Are there any news on this?

ransagy on 18 Sep 2019

Sorry, @ransagy, I completely moved to other topics. But right, I should complete what I promised. @ale7canna, would you like to help me with this?

arialdomartini on 22 Sep 2019

👍1

Is there any progress on this? We need this for a new feature we're building at https://github.com/stryker-mutator/stryker-net