Ledger-live-desktop: No mouse "pointer" cursor hovering over a content of a button

[ghost]

Ledger Live Version and Operating System

• Ledger Live 1.0.0-rc.2
• Platform: macOS

Expected behavior

When hovering over a button, mouse cursor should be set as "pointer".

Actual behavior

When hovering over a button, mouse cursor is set as "pointer" only when inside button's padding area, but is not within button content (icon/text).

Steps to reproduce the behavior

Click on image to see the video:

[gre]

Thanks for the issue.
It seems this is a current limitation of Electron https://github.com/electron/electron/issues/13104

[gre]

it looks like https://electronjs.org/docs/api/frameless-window#custombuttonsonhover would fix it however you no longer see the native button which is not really good option to me

[ghost]

I see.

Might then be worth looking at alternative solutions, e.g. Atom app displays the native title bar:

But also on macOS apps usually don't have "pointer" cursors at all (click on image to see the video):

Or you can just keep an issue open until possibly Electron will resolve it...

[gre]

to retake Atom's example, it does not look like so consistent.
I guess not using pointer at all for the header buttons could be a tmp solution. the fact it hover with a background color make it pretty clear it's an action.

[meriadec]

IMO: If we choose to put cursor default on some buttons, we should do it for all buttons/interactive boxes (except for links like). It's a more native approach and I recommend.

If not, I would go for custombuttonsonhover which is pretty quick to implement.

[gre]

cc @bscholving

[valpinkman]

After a talk with @khalilbenihoud, we've decided to remove the cursor pointer everywhere (except for links), at least until we rework a custom toolbar.