Lbry-desktop: Video player keyboard shortcuts
We already do have https://github.com/lbryio/lbry-desktop/issues/2159 (which was added then removed) and https://github.com/lbryio/lbry-desktop/issues/1395 filed for shortcuts, but I wanted to get a separate issue filed specifically for ones related to the video player.
A few users have asked for the ability to full screen and skip around with arrow keys. Volume control would be another good one. We should look at YouTube to see what other shortcuts they support.
tzarebczan
All 7 comments
I love this feature and would love to see it in the app. I would like to try some fiddle and see where it goes.
pankajpatel
on 2 Oct 2019
Awesome, thanks for taking a look! I added the Hacktoberfest label for you also. Check out https://lbry.com/news/hacktoberfest-2019
tzarebczan
on 2 Oct 2019
Can I work on the issue?
ahmedkrmn
on 6 Oct 2019
Looks like someone claimed it already. @pankajpatel are you still planning to work on it?
tzarebczan
on 6 Oct 2019
Yes, I am checking for solutions available around the internet.
@ahmedkrmn Please go ahead if you have solution in mind; I had something in mind, though it didn't work as expected.
pankajpatel
on 6 Oct 2019
@pankajpatel @ahmedkrmn the solution most likely involves binding to key events and performing the appropriate corresponding action in videoViewer/view.jsx.
kauffj
on 7 Oct 2019
@tzarebczan @kauffj
Above MR #2999 is what I came up with; mimicking some of youtube KB shortcuts
pankajpatel
on 8 Oct 2019
Related issues
tzarebczan
路
13Comments
tzarebczan
路
16Comments
tzarebczan
路
18Comments
tumispro
路
16Comments
kauffj
路
16Comments
Most helpful comment
@pankajpatel @ahmedkrmn the solution most likely involves binding to key events and performing the appropriate corresponding action in
videoViewer/view.jsx.