Trinitycore: [Brewfest] Down with the Dark Iron (full event) [$10 Bounty]

[jasperrietrae]

You will have to replace the RAND define in snake script in npcs_special to RAND_SNAKES since it's also a function.
I'd like to thank Josh, Shauren and some other guys who helped me with this.

C++
https://gist.github.com/1305188

SQL
https://gist.github.com/1305191

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

[nelegalno]

Has anyone tested this?

[LuckerNr1]

i am currently testing with someone else, but need some changes
current state is this sql
edit: newest version http://pastebin.com/CPTya0AP
put SET @GUID in line 44 since the big guids led to typos
all wrong target_type's should be fixed (content of target_type sometimes in action_param6)
also updated quest_template querys to match current table version

[gpascualg]

I tested @Discover's code and it is causing a critical error on the client due to stack overflow.
I'll test your's @LuckerNr1 in a moment and report back.

[LuckerNr1]

the core part is changed as well but not from me, need to ask for permission to post, since its a private repo

[Amit86]

the client still crashes +

spell_gen_dark_iron_knockback_test, i cant find the code for this part and yet its still in the sqls

[gpascualg]

Is it crashing for you @LuckerNr1? If not the problem might be within the c++ itself, although I highly doubt it.
I don't know that much about SAI as to investigate what's not working or causing the stack overflow. I noticed a lot of spawns at the same time, which might be the issue, but I don't really know.

[LuckerNr1]

got the permission for posting the c++ part
c++
http://pastebin.com/3ykyHzPB
updated sql still most credit to @Discover-
http://pastebin.com/CPTya0AP

notes:

• sript ran complete without crash and quest at the end was acceptable
• one spellhack for 42436 cause of problem with target type 110
• there seems to be a problem with multiple summoned gobs ( Mole Machines), they don't despawn. so you have invisible blocks covering the whole place after the event. @Discover- wrote in his sql"they dissapear through another object which makes the despawn animation" but i couldn't find out which one. if im correct, sai still doesnt support gob despawn.

[Vasago]

Any news about this?

[jasperrietrae]

@LuckerNr1: who gave you permission? And since when do you even need permission to share code that was originally written for opensource?

[LuckerNr1]

1. the one who updated your code
2. since it's from a private repo

[milotic]

LuckerNr1 patch need update this
case 42436: // Braufest: Drink!
- spellInfo->EffectImplicitTargetA[0] = TARGET_UNIT_TARGET_ANY;
- spellInfo->EffectImplicitTargetB[0] = 0;
+ spellInfo->Effects[EFFECT_0].TargetA = SpellImplicitTargetInfo(TARGET_UNIT_TARGET_ANY);
+ spellInfo->Effects[EFFECT_0].TargetB = SpellImplicitTargetInfo(0);

[ghost]

Is there anyway to get the achievement ? I could not add the achievement for this.

[milotic]

achievement is for complete quest, this script is for mechanic for get this quest.

[ghost]

@milotic
Do you get the achievement for completing the quest and does that patch still work. I can't get it to work to try it out.
I tried to manually give myself the achievement and it wouldn't do it.

[Anonymous2]

Can some good soul update the c++ and sql files for latest trinity 4.3.4?

[elperro22]

The client still crashes with Stack Overflow error in last tc release.

[ghost]

@elperro22

The client still crashes with Stack Overflow error in last tc release.

Even if "last tc release" is accurate to you right now, that statement loses its meaning within a few days, maybe just some hours. Please add the core hash and TDB version to your post.

[elperro22]

Tranks for your reply and sorry about this one. Every day I download the last changes from git and update my TDB, I don't know how can I check the hash of my version.

[nelegalno]

@elperro22 the easiest way is by opening the Server.log file and checking the 4th line - the string right after "TrinityCore rev. " or you could copy/paste the whole line.

[Aokromes]

Or simply look the last row after server startup.

[elperro22]

Thanks!! Mmmm it's strange, in the two lines it's this one "TrinityCore rev. unknown 1970-01-01 00:00:00 +0000 (Archived branch) (Win32, Release) (worldserver-daemon)"

[Aokromes]

http://www.trinitycore.org/f/topic/345-howto-properly-install-git-on-windows-fix-trinitycore-rev-1970-01-01-000000-0000/

[elperro22]

Thank you Aokromes. 961aaf5 is the version.

[elperro22]

The C++ code is the same so I edited SQL code to this one http://pastebin.com/ZecUfAvf

[elperro22]

Now I have b74ef3f and TDB 56 and the issue persist.

[digz6666]

Anyone giving love to this issue :)

[Kittnz]

Maybe a status update would be nice, what is working and what is not? Are some parts already implemented?

[jasperrietrae]

Sorry I have no clue. It's been 4 years since I did this, code style is horrible too.

[Aokromes]

Anyone can takeover this fix and make a PR with the needed parts?

[Tauriella]

Any News ?

[jasperrietrae]

Holy shit, this is already 6 years ago?!

[Kittnz]

I might check into this again too.

[peycho]

Did anyone test it?

[funjoker]

@peycho make sure to redeploy or withdraw your bounty. New TOS of bountysource will "steal" your money if you dont do so.

[peycho]

I'm not sure how to do that...

[funjoker]

@peycho you can write an email at their support.
May check your mails. It’s described in there

[peycho]

My gosh. I read the e-mail now.
WTF, that's illegal.

Thanks @funjoker

[peycho]

I wrote them:

Hello.
That's kinda illegal if you ask me.
It's more like: Hey we will collect some of the bounties with no reason.
If this is an joke, it's not funny.

If you're intending to do such changes, implement the option in the site so the people can withdraw their bounty when nobody can solve their issue. You can still collect your commission.

My account is ...........
Refund my open bounties and you can cancel my account, otherwise you'll meet my lawyer and that would be fun.

With no regards.
P.

Today's e-mail from bountysource:

Withdrawal of new Terms of Service
Yesterday, we communicated a change to the Bountysource Terms of Service (ToS) agreement.
These changes have been withdrawn and the ToS reverted to its prior state.
The ToS will be revised and clarified in the future.

Thankyou

I guess they came to conclusion that this is actually really wrong.