Lagom: Duplicate Sec-WebSocket-Protocol headers in response

Created on 27 Jul 2019 · 7Comments · Source: lagom/lagom

Potential bug with websockets response. I get 2x Sec-WebSocket-Protocol headers in response if I open websocket with a protocol parameter in JS like this var socket = new WebSocket("ws://localhost:9000/ws", "some-arbitrary-text");

Lagom 1.5.1
Typical bidi streaming service signature: def stream(): ServiceCall[Source[String, NotUsed], Source[String, NotUsed]]

good first issue help wanted

Source

kotdv

Most helpful comment

Chrome throws a console error about that behavior (duplicate headers) and websocket client dies. So it's kind of blocking issue really.

play2.js:74 WebSocket connection to 'ws://localhost:9000/ws' failed: Error during WebSocket handshake: 'Sec-WebSocket-Protocol' header must not appear more than once in a response

kotdv on 29 Jul 2019

👍2

All 7 comments

Thanks for reporting. Apart from that, do you observe any mal-functioning on the client-side caused by this duplication?

octonato on 29 Jul 2019

Chrome throws a console error about that behavior (duplicate headers) and websocket client dies. So it's kind of blocking issue really.

play2.js:74 WebSocket connection to 'ws://localhost:9000/ws' failed: Error during WebSocket handshake: 'Sec-WebSocket-Protocol' header must not appear more than once in a response

kotdv on 29 Jul 2019

👍2

Ok, fair enough.

Would you have time to send a PR for this?

octonato on 30 Jul 2019

any workaround for this?

jayachandrak on 28 Oct 2019

Hi @jayachandrak, this is not currently planned as a high priority on our short-term schedule but if you can send a PR we'll gladly have a look and merge it.

ignasi35 on 4 Nov 2019

This issue still persists and the fix has not been implemented or rolled out. Why? This basically blocks web socket development in Chrome and even in iOS.