Lagom: Add a default .gitignore file to the Maven archetype

[TimMoore]

The Giter8 template has one. We should add this to the Maven archetype as well and keep them in sync.

[dmitraver]

hi, I can pick this one.

[jkremser]

pls close this, if it's done

[octonato]

This is done. Closing

[TimMoore]

I'm reopening this because projects created from the archetype still don't contain the .gitignore file as hoped.

It seems this requires some additional workarounds:

• https://issues.apache.org/jira/browse/MRESOURCES-190
• https://stackoverflow.com/questions/7981060/maven-archetype-plugin-doesnt-let-resources-in-archetype-resources-through

@dmitraver if you'd still like to work on this, that would be a great contribution. Please be sure to test that projects from the archetype contain the .gitignore file.

You can run sbt maven-java-archetype/publishM2 in the Lagom project to install the SNAPSHOT version of the archetype to your local Maven repository, then create a project with it by running the following:

mvn archetype:generate -DarchetypeGroupId=com.lightbend.lagom -DarchetypeArtifactId=maven-archetype-lagom-java -DarchetypeVersion=1.4.0-SNAPSHOT

[dmitraver]

Yup, I could take a look.

Sent from my iPhone

On 11. Oct 2017, at 21:15, Tim Moore [e-mail] wrote:

I'm reopening this because projects created from the archetype still don't contain the .gitignore file as hoped.

It seems this requires some additional workarounds:

https://issues.apache.org/jira/browse/MRESOURCES-190
https://stackoverflow.com/questions/7981060/maven-archetype-plugin-doesnt-let-resources-in-archetype-resources-through
@dmitraver if you'd still like to work on this, that would be a great contribution. Please be sure to test that projects from the archetype contain the .gitignore file.

You can run sbt maven-java-archetype/publishM2 in the Lagom project to install the SNAPSHOT version of the archetype to your local Maven repository, then create a project with it by running the following:

mvn archetype:generate -DarchetypeGroupId=com.lightbend.lagom -DarchetypeArtifactId=maven-archetype-lagom-java -DarchetypeVersion=1.4.0-SNAPSHOT
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

[saniyatech]

Hello Tim,

I worked out a solution for this issue. Can I submit a PR?

Thanks

[saniyatech]

I submitted a PR with a fix for this issue. The build is passing all the tests. I performed the manual test mentioned by Tim to publish the archetype and then generated a project from it. The '.gitignore' file was successfully added to the generated project.

PS: It wasn't a newbie problem, but I use sbt on a daily basis at work and so I was able to contribute!

Hacktoberfest

[TimMoore]

Thanks @saniyatech!