Koreader: Problem in select RTL text

Created on 2 Jan 2020  ·  4Comments  ·  Source: koreader/koreader

  • KOReader version: 2019.12
  • Device: Kindle Paperwhite 3

Issue

if you open a RTL book with koreader highlight and selection is LTR mode

Steps to reproduce

open a RTL book try to long touch a world in middle of sentence try swap to next line.
for example in this text you can long touch on راست and swap to ‍‍است in next line

نوشتار راست به چپ در
این متن نمایش داده شده است

it should select

راست به چپ در
این متن نمایش داده شده است

but it select

این متن نمایش داده شده است

highlight work like a LTR text.
i can send screenshot, if you need that

CREngine

Most helpful comment

EPUB or PDF ?
If with PDF, I can't say much.

If with EPUB/HTML, there is a thing with the "in-progress selection" that is made directly by crengine while you are selecting, which is a bit rough, and impossible to make it do LTR/BIDI, and will indeed show the selection LTR:
image

But once you have highlighted it, the selection is corrected and displayed correctly RTL.
image

I was hoping RTL users would be ok with this little inconvenience :)
(If you need to correct the selection once its highlighted, you can tap on it and move the extremities to grab more words... if that might help living with it.)

The solution would be to not let crengine do the in-progress selection, and do it ourselves like we do the final highlight drawing - may be some day.

All 4 comments

EPUB or PDF ?
If with PDF, I can't say much.

If with EPUB/HTML, there is a thing with the "in-progress selection" that is made directly by crengine while you are selecting, which is a bit rough, and impossible to make it do LTR/BIDI, and will indeed show the selection LTR:
image

But once you have highlighted it, the selection is corrected and displayed correctly RTL.
image

I was hoping RTL users would be ok with this little inconvenience :)
(If you need to correct the selection once its highlighted, you can tap on it and move the extremities to grab more words... if that might help living with it.)

The solution would be to not let crengine do the in-progress selection, and do it ourselves like we do the final highlight drawing - may be some day.

thanks
i am not test that on pdf yet
i test that and it select correct sentence after highlight or note on that.
but it is a little confusing at the first time.
by the way support RTL is awesome and thanks for that.
i hope this small bug can be fix in following version
should i close this issue or keep it open?

Let's keep it open.

(^ closed but not yet available, it will be in a few days)

Was this page helpful?
0 / 5 - 0 ratings