Koreader: minor bug: "more plugins" stays when all plugins are disabled.

Created on 8 Oct 2019  路  4Comments  路  Source: koreader/koreader

  • KOReader version: all
  • Device: all

Issue

More plugins stays as a menu even when there's no content to show.

Steps to reproduce

Disable the following plugins:

"auto_frontlight",
"battery_statistics",
"synchronize_time",
"keep_alive",
"doc_setting_tweak",
"terminal",

device-2019-10-08-183232

bug

Most helpful comment

Of course, the menus are customizable. You can put your overrides in settings/reader_menu_order.lua and settings/filemanager_menu_order.lua. The defaults can be found in ui/elements.

NB You should only put your overrides in there unless you want a maintenance burden.

Concretely, something like this:

local order = {
    tools = {
        "read_timer",
        "calibre_wireless_connection",
        "evernote",
        "statistics",
        "progress_sync",
        "wallabag",
        "zsync",
        "news_downloader",
        "send2ebook",
        "text_editor",
        --~ "----------------------------",
        --~ "more_plugins",
        "plugin_management",
    --~ },
    --~ more_plugins = {
        "auto_frontlight",
        "battery_statistics",
        "synchronize_time",
        "keep_alive",
        "doc_setting_tweak",
        "terminal",
    },
    ["KOMenu:disabled"] = {
        "more_plugins"
    },
}

return order

If you don't explicitly disable submenus or items, they'll pop up as new in the left-most menu. That's intended so that people who customize their menus are alerted of new features.

All 4 comments

Is there any way to disable that submenu but keep plugins on? Make them show on main menu?
I have two plugins in main part and 4 plugins in "more plugins" and it would be better to show all of them without additional submenu.

Of course, the menus are customizable. You can put your overrides in settings/reader_menu_order.lua and settings/filemanager_menu_order.lua. The defaults can be found in ui/elements.

NB You should only put your overrides in there unless you want a maintenance burden.

Concretely, something like this:

local order = {
    tools = {
        "read_timer",
        "calibre_wireless_connection",
        "evernote",
        "statistics",
        "progress_sync",
        "wallabag",
        "zsync",
        "news_downloader",
        "send2ebook",
        "text_editor",
        --~ "----------------------------",
        --~ "more_plugins",
        "plugin_management",
    --~ },
    --~ more_plugins = {
        "auto_frontlight",
        "battery_statistics",
        "synchronize_time",
        "keep_alive",
        "doc_setting_tweak",
        "terminal",
    },
    ["KOMenu:disabled"] = {
        "more_plugins"
    },
}

return order

If you don't explicitly disable submenus or items, they'll pop up as new in the left-most menu. That's intended so that people who customize their menus are alerted of new features.

Of course, the menus are customizable. You can put your overrides in settings/reader_menu_order.lua and settings/filemanager_menu_order.lua. The defaults can be found in ui/elements.

It works, thanks. Would be great if there is a toggle (in plugin management, for example) that allows to do that without creating lua files though.

The menu structure is the way it is by design. The fact that these are all plugins is an irrelevant technical detail from a UX viewpoint.

PRs welcome for a full LibreOffice-style menu customization UI. ;-)

Was this page helpful?
0 / 5 - 0 ratings

Related issues

Anuvadak picture Anuvadak  路  4Comments

gerroon picture gerroon  路  4Comments

worldexplorer picture worldexplorer  路  4Comments

fayebian picture fayebian  路  5Comments

Eduardomb22 picture Eduardomb22  路  3Comments