Kops: Support additional kubelet flags in componentconfig

Created on 17 Jan 2019  路  16Comments  路  Source: kubernetes/kops

1. Describe IN DETAIL the feature/behavior/change you would like to see.

Some kubelet flags listed here:

https://kubernetes.io/docs/reference/command-line-tools-reference/kubelet/

..are seemingly not supported by kops:

https://github.com/kubernetes/kops/blob/f5ce011fa036034e8b40d0dc94bc5bfc2419bc56/pkg/apis/kops/componentconfig.go

We found some are useful, e.g., --housekeeping-interval.

2. Feel free to provide a design supporting your feature request.

good first issue hacktoberfest help wanted

Most helpful comment

We have been having issues with Docker crashing due to PLEG errors. The suggested mitigation is to increase the housekeeping interval described here. Shame that this feature is not part of kops!

All 16 comments

good explanation about performance improvements with --housekeeping-interval option enabled.
https://github.com/kubernetes/kubernetes/issues/18044

/assign nareshku

@nareshku: GitHub didn't allow me to assign the following users: nareshku.

Note that only kubernetes members and repo collaborators can be assigned and that issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign nareshku

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

good explanation about performance improvements with --housekeeping-interval option enabled.

@nareshku Are you suggesting that the decision of "having this flag enabled by default" should be made by kops and for all kops users? Excuse me - but please read and understand this issue carefully :)

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

/remove-lifecycle rotten

It will be useful to have the ability to configure a kubelet's housekeeping.

We have been having issues with Docker crashing due to PLEG errors. The suggested mitigation is to increase the housekeeping interval described here. Shame that this feature is not part of kops!

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Can this be enabled for the kubelet?

/reopen
This seems pretty straight forward and would be a good candidate for #9920

@rifelpet: Reopened this issue.

In response to this:

/reopen
This seems pretty straight forward and would be a good candidate for #9920

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

owenmorgan picture owenmorgan  路  3Comments

justinsb picture justinsb  路  4Comments

mikejoh picture mikejoh  路  3Comments

chrislovecnm picture chrislovecnm  路  3Comments

Caskia picture Caskia  路  3Comments