Kolibri: proper handling of lesson with no resources

Created on 19 Feb 2019  路  9Comments  路  Source: learningequality/kolibri

Observed behavior

Able to create a lesson without resources. Coach user must not able to create a lesson without resource.
When you create a lesson without resource, it will show you a completed by 2 of 2 in report.

Steps to reproduce

  1. Create lesson without resource and active the lesson.
  2. and see report for the lesson.

Context

  • Kolibri version : Kolibri 0.12.0b4
  • Operating system : Ubuntu 14.04
  • Browser : chrome

Screenshot

screenshot from 2019-02-19 12 15 16

P1 - important bug

All 9 comments

Currently, being able to create a lesson without resources is by design because lessons use an 'auto-save' functionality. This is different from quizzes which has an explicit 'save' step. We may revisit this in the future, but that's a separate issue. (cc @khangmach @jtamiace)

However, there are two things we should do:

  1. make sure that empty lessons don't show up for learners
  2. either hide empty lessons from reports entirely, or make them show up as 'not started' rather than 'completed'

We can also disable the 'change' link on the lesson details page, then re-enable it when they have at least one resource

Still extant on beta9.

@radinamatic The patch that should hopefully fix this is still open. You can test it by pulling #5140

Thanks, @jonboiser, missed that one :confused:

same issue found on kolibri 0.12.0 beta 12
kolibri.log
server.log
image

5235

Checked it in 0.12.0. And work as expected.
lesson proper result

thank you!

Was this page helpful?
0 / 5 - 0 ratings