Kiwix-android: Confirm delete dialog shown multiple number of time when deleting more than one zim

[yashk2000]

Is your feature request related to a problem? Please describe.

Currently, when a user selects more than one zim to be deleted, a dialog is shown for every zim to be deleted. While this might be fine for 1-2 zims being deleted, but when a user will be deleting a large number of zims, this dialog will become a bit cumbersome. The user will have to press delete for every zim to be deleted.

Describe the solution you'd like

When more than one zim is being deleted, just show one dialog asking for confirmation from the user for deleting all the detected zims.

Additional context

I would like to work on this.

[4shutosh]

I think asking confirmation for each zimFile is necesarry, because the app works offline and if the user does not have internet access it will be a hard time to download the zim file again (which usually is big in size).
It might be cumbersome for the users who have easy internet acces all the time but we target the people who don't have internet access all the time.

[yashk2000]

We will be showing a general dialog asking for confirmation before deleting.
But imagine you're deleting even just 5 files. It will be too much for the user to click delete 5 different times. Even here, mostly a user will not even read the names of all files being deleted. After 2-3 files, a user will just keep pressing the delete button continuously until all selected files are deleted.
For confirmation, the user is first selecting the files by himself, then clicking the delete icon(aware that a trash button means deletion) and then a dialog will also be shown.
I think a user is sensible enough to see which files he is actually selecting for deletion.

Even apps such as photo applications don't ask for confirmation while deleting multiple photos for each photo.

[yashk2000]

@macgills should I proceed with this?

[macgills]

It would be cool if we showed a custom dialog that you can scroll with all the titles of the zims you are about to delete. Individually deleting is slow and tedious

[yashk2000]

@macgills is a dialog like the screenshot below fine:

Instead of creating a custom dialog, I used the DeleteZim data class already present in KiwixDialog itself. This list is also scrollable if a lot of zims will be deleted at once.

[macgills]

@yashk2000 show me what it looks like with so many entries that it has to scroll.

I don't think the numbering is necessary.

[yashk2000]

@macgills on it. I won't be able to download enough zims for this purpose though. I'll just make a custom list with my own words and put it in this dialog.

[yashk2000]

[yashk2000]

@macgills it looks like the above gif.

[macgills]

Works great for me