Kiwix-android: Specify round icon in AndroidManifest

Created on 1 Apr 2018  路  4Comments  路  Source: kiwix/kiwix-android

Environment

  • version of the software you use: 2.3
  • device / operating system: Moto G5S / Android 7.1.1

The Bug:

The circular icon of the app is not shown by the launchers using circular icons.

Screenshot:
image

bug good first issue

Most helpful comment

@Rahul5758 I don't think this is a big change. I have only added a single line and we do have the round icon which was unused till now. Someone who has added the icon must have forgotten to define it in the manifest file. An excerpt from https://developer.android.com/about/versions/nougat/android-7.1.html#circular-icons :

apps should make sure to define both android:icon and android:roundIcon resources when responding to launcher intents

All 4 comments

@abdulwd In your screenshot there are other apps too which do not have an round icon, so I don't think its necessary to specify a round icon.

@Rahul5758 I don't think this is a big change. I have only added a single line and we do have the round icon which was unused till now. Someone who has added the icon must have forgotten to define it in the manifest file. An excerpt from https://developer.android.com/about/versions/nougat/android-7.1.html#circular-icons :

apps should make sure to define both android:icon and android:roundIcon resources when responding to launcher intents

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

@abdulwd Please let me know how this commit works for you all.

Was this page helpful?
0 / 5 - 0 ratings