Kiwix-android: Search result selection is not haptic

Created on 7 Mar 2020  路  8Comments  路  Source: kiwix/kiwix-android

Steps:

  • Load a ZIM file
  • Make a search and select any result

What I get:

  • The item select is not visually higlighted before the content is loaded. The article is properly loaded.

I want:

  • To see clearly, by a highlight operation, which item i have chossen, before the content is loaded... like in any list.
enhancement good first issue

All 8 comments

@kelson42 Would like to work on this! Please assign.

I'm assuming you are not working on this as well @dipu989. I'd like to work on this if that is the case.

@kelson42 I am not sure what you mean by this. Currently, when I select an item, it is 'highlighted' by being tinted gray for half a second after of which the page loads. Can you give an example of a list item being more clearly highlighted in some other app or show an image?

There was a PR that added this effect very recently if I am not mistaken

@macgills ok, so this is probably resolved then?

If you can post a screenshot here and validate it with @kelson42 then we can happily close it

This is what the search selection looks like currently. Tell me if it needs updating @kelson42.

untitled

@kelson42 this looks fine to me, closing

Was this page helpful?
0 / 5 - 0 ratings