Kiwix-android: Refactor LocalFileTransfer: Use Coroutines instead of AsyncTasks

[Aditya-Sood]

• feature/LocalFileTransfer currently uses async-tasks for transferring files, metadata exchange, etc.
• Aim of this ticket is to replace said async-tasks and use rx instead
• I'll be working on this ticket once #1276 has been merged

[kelson42]

@Aditya-Sood Which kind a problem (from a user perspective) this ticket should fix? Why it has not been written with RX in a first place?

[macgills]

Aditya would have had to learn Rx which was mildly out of scope for the original ticket so we decided to not spend the time there but make a ticket to improve it. From a user perspective there should be zero impact. From a code perspective way nicer.

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

[gouri-panda]

@macgills if @Aditya-Sood is not working can I take this issue?

[macgills]

@gouri-panda assigned

[macgills]

It may be noted that coroutines are also a much more valid option here than they were when this ticket was first made. The API stabilised a lot and they have been overwhelming embraced by the jetpack team

[gouri-panda]

@macgills I'm also favored with Coroutine.Should i make another ticket for this?

[macgills]

Nah you good, ticket was always about coroutines 👀

[gouri-panda]

@macgills How about kotlin?

[macgills]

Kotlin is non negotiable, coroutines + java is not possible

[gouri-panda]

Should I make another ticket for converting to kotlin?

[macgills]

It is discrete enough that it can just be done as part of this ticket, the activity is already in kotlin

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.