Kiwix-android: Search should be available from new tab menu

[mhutti1]

It should be possible to search from the new tab menu and the search to open in a new tab.

[ghost]

Ya, I also found a new tab opening up completely blank and found that not that good looking. BTW, Hi, I am new to kiwix-android. Found this app useful and felt like contributing.

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

[mhutti1]

[mhutti1]

A search icon should be added to the bar to allow users to search into a new tab.

[mohamed-sameh-khalil]

I would like to work on this issue

[mohamed-sameh-khalil]

I also noticed we could reach a state were in the search icon is completely invisible

steps to reproduce

Open a new tab then press on the tabs button then choose any tab(could be the same tab again). The chosen tab will not have a search icon

[kelson42]

@mohamedsamehkhalil I have assigned the ticket to you.

[mohamed-sameh-khalil]

activity.intent<SearchActivity> {
        putExtra(EXTRA_ZIM_FILE, zimFileReader.zimFile.absolutePath)
      }

@mhutti1 The search that is currently implemented takes in a Zim file to search in. Do you expect the search from a new tab to look into all files or just one specific file ?

[kelson42]

@mohamedsamehkhalil This should work for the current ZIM open.

[mohamed-sameh-khalil]

@kelson42 so just to be sure I understand the issue correctly. The screen that appears when I press on the tab switcher button and view all tabs, this is where I should add the search button, correct ?

[4shutosh]

Yes @mohamedsamehkhalil
We should be able to search from this screen
Adding a search button in this bar will work fine.

[mohamed-sameh-khalil]

@mhutti1 @kelson42 I finished working on a solution for the issue but the commit hooks fail because of detekt.yml maximum threshold of 11 functions in classes in SearchActivity.kt and MainMenu.kt
What should I do ?

detekt.yml part:

TooManyFunctions:
    active: true
    excludes: "**/test/**,**/androidTest/**,**/*.Test.kt,**/*.Spec.kt,**/*.Spek.kt"
    thresholdInFiles: 11
    thresholdInClasses: 11
    thresholdInInterfaces: 11
    thresholdInObjects: 11
    thresholdInEnums: 11

[mhutti1]

I imagine this means you have too many functions in the classes it specifies? I imagine you should move some out into a seperate class?

[mohamed-sameh-khalil]

@mhutti1 I solved the detekt problem thanks to help from macgills and was able to push my solution correctly. please review my pull request #1859 and inform me of your edits or requests.