Kiwix-android: History is cleared even when no history is present

[sonusourav]

Describe the bug
In history activity, even when no history is present if the user selects clear no history, the Toast says All history cleared.

Expected behavior
The Toast should be No history present.

Steps to reproduce the behavior:

1. Open history and select Clear History from the overflow menu.
2. Once again, select Clear history.
3. Toast says All history cleared.

Screenshots

Environment

• Version of Kiwix Android : 2.4 Build 55
• Device : Redmi 4
• OS version : Android Nougat 7.1

[ritik2017]

I would like to work on the issue

[abdulwd]

Instead of making a different toast hide the option from the menu.

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

[kelson42]

@mhutti1 @abdulwd @macgills Do we really need that? I'm not sure this is really worth it.

[macgills]

I will admit to being largely indifferent. it is a good first issue though

[kelson42]

@mhutti1 @abdulwd @macgills Do we really need that? I'm not sure this is really worth it.

[kelson42]

After discussing with @macgills we want the following:

• Remove the menus
• Create an icon in the topbar to enable/disable the display of all (versus current) book/tab history
• Replace the 3dots menu with a simple trash icon. The click on trash should simply delete what is displayed.

[abdulwd]

@kelson42 I think we don't need it.

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

[devanshi7799]

can i work on this?

[kelson42]

@devanshi7799 Yes, you are welcome.

[devanshi7799]

@kelson42 Thank you so much :)

[devanshi7799]

can you tell me how to claim this issue?

[macgills]

@devanshi7799 you are now assigned

[devanshi7799]

@macgills I have worked on the issue but when i am trying to make a pull request it is showing me some error. Can you help me solve it?

[kelson42]

@devanshi7799 What happens exactly?

[devanshi7799]

@kelson42

It is showing me this type of error

[kelson42]

@devanshi7799 OK, this is a compilation error. This is not related to a PR I believe. To make a PR, you just need to https://github.com/kiwix/kiwix-android/pulls. @macgills will try to help you witin a few hours.

[abdulwd]

It seems like pre-commit hook is failing. @devanshi7799 Are you able to build & install this app?

[devanshi7799]

@abdulwd yes, the application is running perfectly fine on my phone

[abdulwd]

@devanshi7799 Try to commit using command line git commit -m <some-message> and then check why the pre-commit hook is failing. If you're not able the figure that out then paste those logs here.

[devanshi7799]

@abdulwd it is showing this.

[macgills]

one of these tasks is failing

gradlew ktlintCheck app:lintDebug core:lintDebug custom:lintCustomexampleDebug

run them in terminal and post the output here.
Also verify you do in fact have the file custom/src/customexample/info.json

[macgills]

Ah no it is just that you don't have JDK8 installed

If the build failed for another reason please make sure JAVA_HOME is set to JDK8

[macgills]

I'm gonna update that message to be way more prominent

[devanshi7799]

@macgills is it necessary to have JDK version set to 8? or higher version is okay?

[macgills]

8 is absolutely necessary. Higher is not, android does not support it