Kiwix-android: Fix Checkstyle issues

[mhutti1]

There are approximately 800 checkstyle warnings. We need to fix the issues or in some cases update rules.

[kelson42]

@mhutti1 Could you please share here the command to get the list?

[RajaVamsi11]

@mhutti1 How can we get list of checkstyle warnings?
Now i am going through concept of checkstyle and writing rules, i will fix this issue as soon as possible.

[mhutti1]

Download the checkstyle plugin for android studio and configure it with https://github.com/kiwix/kiwix-android/blob/master/config/checkstyle/checkstyle.xml

[kelson42]

The implementation of this ticket seems really important to save a lot of reviewers time.

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

[kelson42]

@macgills What the current situation and feeling about this ticket? My opinion is that if we don't want checkstyle to report problem then it should be part of the CI.

[macgills]

https://docs.gradle.org/current/userguide/checkstyle_plugin.html we can add it

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

[macgills]

@kelson42 rather than supporting checkstyle which is java only we would probably be more suited to switching this ticket to "integrate detekt" and view remaining java code as "should be rewritten in kotlin"

[kelson42]

@macgills "detekt" is not already run by https://www.codefactor.io ?

[macgills]

If codefactor is running detekt it is running a very lenient or much earlier version

[macgills]

@kelson42 is this ticket now "Integrate detekt and fix issues" or "Fix checkstyle issues"?

[kelson42]

@macgills Both.

[kelson42]

Just to be surw, this ticket is not a duplicate of #1274?

[macgills]

totally different

[macgills]

@kelson42 I had forgotten checkstyle was only a format checker and didn't actually check for any bugs at all.

I don't think it is worth our time integrating it for the dwindling 43% of the code that remains in java when our formatter is already in source control and ktlint runs on our kotlin and automatically formats it.

Checkstyle does not support autofixes beyond what we already have so I don't think its integration will be particularly useful.

[macgills]

@kelson42 there is still a PR that integrates detect so I am reopening this and will move that Pr from draft to Ready for Review