Kirki: Themecheck plugin showing an error about Kirki text domain
Issue description:
I am using Kirki framework to develop a WordPress theme. After completing the theme I tested my theme using theme check plugin. It throws an error
More than one text-domain is being used in this theme. This means the theme will not be compatible with WordPress.org language packs. The domains found are myTheme, kirki.
I ignored this issue and submitted my theme to themeforest.net but the review team asked me o solve this issue. Is there anyway i can solve this issue.
hussainnayani
All 4 comments
Ideally you wouldn't be including kirki in your theme... You can instead require its installation as a plugin. This way your users will also get any future bugfixes and improvements simply by updating the plugin.
If you don't want to do that and insist on including Kirki in your theme, then there's nothing to worry about...
Kirki has a separate implementation for localizations when used inside a theme: https://github.com/aristath/kirki/blob/develop/l10n.php
The WPTRT team is aware of that and in fact the textdomain is whitelisted when submitting a theme in wordpress.org for exactly that reason (hybrid-core is another one that is whitelisted because they both use the same implementation).
You can point this out to the theme reviewer and link to this thread here, if there any more questions from them I would be more than happy to answer them.
If you don't want to do that either, then you can just manually go through the files and change all 'kirki' textdomains to your own.
aristath
on 26 Sep 2017
@aristath Great.! Thank-you so much for your answer.
hussainnayani
on 27 Sep 2017
I think You have also defined some classes like this 'kirki' → changing that might also change few classes.
fastmarketo
on 6 Oct 2017
@fastmarketo No, I just checked to be 100% certain.
The error you describe on https://github.com/aristath/kirki/issues/1551#issuecomment-334398908 can only be cause if you replaced , 'Kirki' (with a capital K) in this line: https://github.com/aristath/kirki/blob/3.0.10/class-kirki-autoload.php#L52 in my previous comment there.
aristath
on 6 Oct 2017
Related issues
2one2
·
3Comments
ravishakya
·
7Comments
hellor0bot
·
3Comments
rahulv3a
·
3Comments
fakrulislam
·
3Comments
Most helpful comment
Ideally you wouldn't be including kirki in your theme... You can instead require its installation as a plugin. This way your users will also get any future bugfixes and improvements simply by updating the plugin.
If you don't want to do that and insist on including Kirki in your theme, then there's nothing to worry about...
Kirki has a separate implementation for localizations when used inside a theme: https://github.com/aristath/kirki/blob/develop/l10n.php
The WPTRT team is aware of that and in fact the textdomain is whitelisted when submitting a theme in wordpress.org for exactly that reason (
hybrid-coreis another one that is whitelisted because they both use the same implementation).You can point this out to the theme reviewer and link to this thread here, if there any more questions from them I would be more than happy to answer them.
If you don't want to do that either, then you can just manually go through the files and change all
'kirki'textdomains to your own.