The CLI in particular should output valid instructions for setting KUBECONFIG on Windows ideally, this might be a bit tricky as technically you could also be in bash on windows, and this may open a whole can of worms to detect correctly :-)
/kind feature
/priority important-longterm
/help
xref #155 #190
@BenTheElder:
This request has been marked as needing help from a contributor.
Please ensure the request meets the requirements listed here.
If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.
In response to this:
The CLI in particular should output valid instructions for setting KUBECONFIG on Windows ideally, this might be a bit tricky as technically you could also be in bash on windows, and this may open a whole can of worms to detect correctly :-)
/kind feature
/priority important-longterm
/helpxref #155 #190
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Can I take this? Need something cool to get back from the holiday slump :smiley:
Sure! 馃槃
I think we might need some tricky business for this one, depending on what shell the user is in. Can't just use POSIX :(
So I've been looking up into this. I'll add some more documentation and will focus mostly on using kind in powershell. Git bash seems to more or less work as expected and the command prompt itself behaves very much like powershell.
Please tell me if there is some other type of environment that you think should be tested :-)
I think cmd.exe and powershell are indeed the main targets, but I'm not really a windows developer, let's start there and look for feedback in the future :-)
/assign
with this PR the CLI prints shell instructions for Windows:
https://github.com/kubernetes-sigs/kind/pull/326
should the docs include these Windows shell instructions here?
https://github.com/kubernetes-sigs/kind/blob/master/site/content/docs/user/quick-start.md#interacting-with-your-cluster
yeah, at least they should link to another section with them, I'm not sure if we want to detail every shell inline there 馃
(note this issue is almost solved, but I want to track which issues would be good first issues to see if we're having them at all. if we're not we should aim to write more well-scoped issues...)
do we still need to track this?
I think we're in pretty good shape now.