Kind: Use go modules compatible tags
What happened:
The tags in this repository are named 0.2.1, 0.2.0, 0.1.0, 0.0.1
When executing go get with modules enabled, it always gets the latest version, not a tagged one, because it expects semver tags prefixed with a v, meaning tags like v0.2.1.
What you expected to happen:
Go get fetches the last tagged (valid) semver release.
In this section, "latest" is the latest version with a semver tag, or the latest known commit if there are no semver tags.
https://github.com/golang/go/wiki/Modules#how-to-upgrade-and-downgrade-dependencies
How to reproduce it (as minimally and precisely as possible):
go get sigs.k8s.io/kind
tommyknows
All 3 comments
That's a bit annoying, https://semver.org/ does not use a leading v 馃檮
BenTheElder
on 7 May 2019
We will use vX.Y.Z going forward.
/assign
BenTheElder
on 7 May 2019
I've pushed vX.Y.Z tags for every existing X.Y.Z tag, please let me know if you have any problems. I'm looking at converting the repo fully to modules now :sweat_smile:
BenTheElder
on 7 May 2019
Related issues
rajalokan
路
3Comments
cjwagner
路
3Comments
Wenshiqi222
路
4Comments
leelavg
路
3Comments
cig0
路
4Comments
Most helpful comment
I've pushed vX.Y.Z tags for every existing X.Y.Z tag, please let me know if you have any problems. I'm looking at converting the repo fully to modules now :sweat_smile: