Kind: support all the kubeadm config flavors in templates

[neolit123]

the kubeadm configuration is moving fast and ever changing.
it was v1alpha2 in 1.11 and in 1.12 it would be v1alpha3.
even more changes are planned for v1beta1 in 1.13.

based on a parseable kuberentes-version flag of sorts, kind would have to pick the right template to construct a kubeadm config.

for ref:
https://github.com/kubernetes-sigs/kind/blob/130a7fe9212c3fba6fc84d785759785218ce5128/pkg/cluster/kubeadm/config.go#L55
kubeadm's api:
https://github.com/kubernetes/kubernetes/tree/master/cmd/kubeadm/app/apis/kubeadm

/assign
/kind feature
/priority important-longterm

[BenTheElder]

Definitely, thanks for filing this.

We know the Kubernetes version from /kind/version (a regular text file containing gitVersion for the kubernetes installed at build time) in the node image, the value of which is supplied to the template as an arg. We probably want to supply a parsed version of this to the template so it can select over minor / patch etc.

[neolit123]

understood, just had a look how the version is passed to the template.

[BenTheElder]

Filed https://github.com/kubernetes/kubernetes/pull/68922 so we can use the same version package as kubeadm to parse versions for this. If that doesn't go through we have other options though..

[BenTheElder]

/lifecycle active

https://github.com/kubernetes/kubernetes/pull/68922 will hopefully go in soonish as the queue drains post code-freeze. once api machinery syncs it out we can import it and add some code to select on kubeadm config types by k8s version.

[neolit123]

kubernetes/kubernetes#68922 will hopefully go in soonish

:+1:

/lifecycle active

@BenTheElder do you need this ASAP? or does the active label imply that you started working on this already? :)

[BenTheElder]

Counting the PR above and discussion here as making it active for now :-)
Trying out the active label for tracking in this repo.

On Tue, Sep 25, 2018, 06:25 Lubomir I. Ivanov [e-mail]
wrote:

kubernetes/kubernetes#68922
https://github.com/kubernetes/kubernetes/pull/68922 will hopefully go
in soonish

👍

/lifecycle active

@BenTheElder https://github.com/BenTheElder do you need this ASAP? or
does the active label imply that you started working on this already? :)

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kubernetes-sigs/kind/issues/7#issuecomment-424341911,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA4Bq_23C5V7zOxwMPZo8r1VJoc0_Vlnks5uei7CgaJpZM4WoUKn
.

[neolit123]

Counting the PR above and discussion here as making it active for now

ok, makes sense :+1:

[BenTheElder]

https://github.com/kubernetes/kubernetes/pull/68922 merged but kind is currently broken and we'll need to wait for it to be synced out by the publishing bot

[neolit123]

i need to figure out what is the best way vendor pkg/util/version in the manifest list e2e that i'm doing too, because i homebrew a semVer in there.

the code has to live in k/kubeadm for this test.

[neolit123]

looking into this right now with pseudo version checks.
do we have to vendor util/version in the kind tree at this point?

[BenTheElder]

Thanks again! fixed in https://github.com/kubernetes-sigs/kind/pull/46

Will probably follow up with revisiting the templates a bit, but we do have support now :-)