Kibana: [Meta] Migrate Kibana plugins to TS project references

[ryankeairns]

@restrry for our planning purposes, is there a target release or deadline for this effort? ty

[restrry]

@ryankeairns @timroes
Making every plugin an independent TS project is a prerequisite for Phase 2 of https://github.com/elastic/kibana/issues/69706. That @elastic/kibana-operations team plans to start in v7.12 (cc @tylersmalley, @mistic)
Ideally, all the plugins migrate to TypeScript projects in v7.11, beginning of v7.12.
The main blocker at the moment is data plugin, I suppose (cc @lukeelmers)

[lukeelmers]

Ack @restrry -- we're sorting out how we want to handle the changes required for data and I'll report back once updates are being made

[cjcenizal]

@restrry According to the docs migration order matters, so plugins at the leaves of the dependency tree won't be able to begin migration until their dependencies have been migrated. Because of the sequential nature of this work, I'd like to set expectations. There are 6 weeks until feature freeze, and ES UI's apps have many unmigrated dependencies. For example, here are Index Management's dependencies:

      data
      expressions
      uiActions
      management
      features
      visTypeTimelion
      visualizations
      embeddable
      savedObjects
      discover
      charts
      visDefaultEditor
      navigation
      security
      taskManager
      securityOss
      spaces
      advancedSettings
      savedObjectsManagement
      dashboard
      esUiShared
      ingestManager
      encryptedSavedObjects
      cloud

Looking at how many dependencies remain to be migrated and how much time remains in the dev cycle, it seems likely that we'll be unblocked with a week or two remaining. This is also typically the time when we're focused on polishing and testing new features in preparation for feature freeze. Sometimes we uncover bugs or opportunities for improvement that we need to execute on in order to ship. With this in mind, i think there's a high probability that some percentage of ES UI's apps (~75%) won't be migrated to TS projects by 7.11 feature freeze.

[legrego]

It's also very likely that the security team's plugins won't be migrated either, as we first have to resolve the circular dependency between security and spaces. I've been working on a POC for this, but time has not been on my side this week. And based on CJ's list ^, we are one of the teams blocking their work.

I am rather surprised that Index Management has a dependency on the spaces plugin though. Is that transient by way of another dependency?

[cjcenizal]

@legrego Yes, it's a transient dependency. Here's the package.json. It has an optional dependency upon security, which is probably the cause of the spaces transient dependency.

[restrry]

i think there's a high probability that some percentage of ES UI's apps (~75%) won't be migrated to TS projects by 7.11 feature freeze.

It's okay. It's not a user-facing feature at the end of the day. All the teams have some space in 7.12 to wrap up this work until @elastic/kibana-operations team starts introducing the new building toolchain.

[timroes]

@restrry Same heads-up from Kibana App side. This was not part of our 7.11 planning. We will try to squeeze some things where possible in, but I'd expect the majority of our plugins not to be migrated in the 7.11 time frame and hopefully we'll be able to get the majority done up to 7.12.

[roaksoax]

@restrry The Logstash team doesn't currently have any UI engineers and we will need someone to take over this work. Is this something you or your team can help with?

[smith]

@roaksoax I''ll help out, but logstash depends on home, and data transitively, so it's probably going to be blocked from getting its own tsconfig set up until those are done.

[smith]

The data plugin is the big rock sitting in the way of this work. I'd say 90% of plugins can't be completed right now because of dependencies on data.

Once that one has the circular dependencies resolved and its references set up it will make things a lot smoother. I've been working a bit on this so I'll try to help out where I can.

[lukeelmers]

Data plugin is next thing on my list to look at; we know it's holding up everyone else. Will report back here with updates.

[lukeelmers]

Update: I have a PR up for resolving the circular dependencies in the data/expressions plugins. A PR will be on the way soon for the uiActions ones.

Once we address those, I'll have a PR which cuts over data, uiActions, and expressions to project refs all in one go, which should unblock a bunch of other plugins.

[legrego]

For those following along, we've eliminated the circular dependency between the security and spaces plugins via https://github.com/elastic/kibana/pull/81891

[pgayvallet]

@lukeelmers any progress on the data plugin migration to project refs?