Kibana: Replace usage of `/elasticsearch/_msearch` endpoint in Index Pattern Management UI

Created on 31 Jul 2020  Â·  9Comments  Â·  Source: elastic/kibana

In order to unblock removing legacy plugin support (https://github.com/elastic/kibana/issues/71927) we need to remove all usages of the /elasticsearch/_msearch endpoint. This can be replaced with a specific endpoint in the index_pattern_management plugin that provides only the needed functionality for the frontend.

https://github.com/elastic/kibana/blob/4eb455dd2474d93090824e6f5c89fa41c69b9078/src/plugins/index_pattern_management/public/components/field_editor/lib/validate_script.ts#L65

Index Patterns Core AppServices blocker technical debt

Most helpful comment

Are we going to need to keep this endpoint until 8.0 in order to not break that feature? Is that a feature we must keep around until 8?

Yes, I believe the plan is to keep that setting around until 8.0

I'm currently working on an /internal/msearch endpoint which has some extra handling which would allow us to close this issue and https://github.com/elastic/kibana/issues/55139 at the same time.

All 9 comments

Pinging @elastic/kibana-app-arch (Team:AppArch)

Just an FYI this isn't the only place the endpoint is used, it's also used if you have the courier:batchSearches setting turned on. (See https://github.com/elastic/kibana/issues/54147 and https://github.com/elastic/kibana/issues/55140.)

@lukasolson Just saw your comment here. Are we going to need to keep this endpoint until 8.0 in order to not break that feature? Is that a feature we must keep around until 8?

If so, maybe the best course of action here is for the Platform team to migrate this endpoint out of legacy and mark it as deprecated.

Are we going to need to keep this endpoint until 8.0 in order to not break that feature? Is that a feature we must keep around until 8?

Yes, I believe the plan is to keep that setting around until 8.0

I'm currently working on an /internal/msearch endpoint which has some extra handling which would allow us to close this issue and https://github.com/elastic/kibana/issues/55139 at the same time.

@lukeelmers I see https://github.com/elastic/kibana/pull/75943 unfortunately did not address this issue. This is still planned for 7.10, right?

pinging @lukasolson since Elmers is out ⬆

Yes, I believe this is still being targeted for 7.10.

I'm actively working on this now, expecting to have a PR ready soon.

Was this page helpful?
0 / 5 - 0 ratings