Kibana: [Ingest Manager] Rename and re-enable EPM api integration tests

Created on 2 Jun 2020  路  6Comments  路  Source: elastic/kibana

For unknown reasons[*], the tests in x-pack/test/epm_api_integration/ are currently not run. Of of the tests is failing due to the changes to index templates v2.

This task is to

  • rename the directory to ingest_management_api_integration
  • fix the failing test
  • enable the tests in CI by adding them to x-pack/scripts/functional_tests.js

[*] This must have happened before the merge to master, so the corresponding commit(s) have been lost to commit squashing, so we don't know what the reason for disabling them was.

beta1 Ingest Management bug

All 6 comments

Pinging @elastic/ingest-management (Team:Ingest Management)

@skh we also have ingest_manager test x-pack/test/api_integration/apis/ingest_manager/ and /x-pack/test/api_integration/apis/fleet/
We probably want to move everything in one place

We should consider this more like a bug than technical deb, I've increased priority on it.

@nchaulet Yes. The reason epm_api_integration is a separate directory is that it has a different config.ts from the ones in api_integration, because it sets a different registry url in the settings.

With https://github.com/elastic/kibana/issues/61699 this will all need to be consolidated, but I think we should get the tests running again first, regardless of when we'll have docker in CI.

Would this separate config.ts still run everything that is in x-pack/test/functional/?

When we (endpoint) were setting up these types of tests that interacted with Ingest APIs we also found that we needed to remove ourselves from the main set of functional test. If I remember correctly, when @jonathan-buttner tried it he got failures in other plugin tests which would have need to be address (maybe a heavy lift?). I'm thinking there may be value in ensuring that Ingest (and SIEM-Endpoint) are run along with other plugins so that we assure runtime compatibility.

(FYI: Endpoint integration tests (x-pack/test/functional_endpoint) are also currently turned off due to the move of code to SIEM. We will be re-focusing on those soon to re-enable them)

/cc: @kevinlog , @nnamdifrankie

@paul-tavares Good points, thanks. I frankly don't know yet. I would prefer if our tests need as little special configuration as possible, too.

/cc: @spalger (JFYI)

Was this page helpful?
0 / 5 - 0 ratings