Kibana: [Uptime] New MonitorList Expanded Row
Add the new expanded row state to from https://github.com/elastic/uptime/issues/79 (screenshot below).
@katrin-freihofner are you OK with us using the current mini-histogram widget on the overview page in lieu of the timeline for now? That task has some significant backend work and I'd rather not block the issue on that.
andrewvc
All 17 comments
Pinging @elastic/uptime
elasticmachine
on 30 Aug 2019
Of course, I'm ok with that. I'm aware that the timeline will be handled separately.
katrin-freihofner
on 2 Sep 2019
@katrin-freihofner can you please give an updated design by using mini-histogram instead of timeline. It will help in implementation :)
shahzad31
on 16 Sep 2019
@shahzad31 I think the best way is, to leave the mini-histogram in a separate column as it is right now. We can remove it as soon as we have the timeline. Does this work for you?
katrin-freihofner
on 17 Sep 2019
@katrin-freihofner @andrewvc in case of down, i see we are displaying, down in location etc etc
In case of Up Monitor , what are we displaying, i remember we having discussion about this, but i am unable to find a decision over that, what we need to display in case monitor is up in expanded state. Can you guys clarify this.
shahzad31
on 19 Sep 2019
I don't recall a discussion about that, but I'm realizing the mock is a bit unclear here. Obviously the status button would change to green/up, but the location list is a bit odd.
What would make sense to me would be to have one line per status. In other words, in a mixed state where two locations are down and one is up we'd show:
[red] Down in location-1, location-2
[green] Up in location-3
@katrin-freihofner would love your feedback here ^^
andrewvc
on 19 Sep 2019
@shahzad31 I'm sorry, that is unclear from the mockup. And yes, it should be like @ andrewvc pointed out (Down first, Up monitors in a second row).
katrin-freihofner
on 20 Sep 2019
katrin-freihofner
on 20 Sep 2019
@andrewvc @katrin-freihofner another question, where are we accommodating the ad_location link button? Which leads to a guide.
Are we skipping it in new design?
shahzad31
on 20 Sep 2019
Good question, @katrin-freihofner where would you like that link to go?
andrewvc
on 20 Sep 2019
@shahzad31 good question.
I see multiple options:
- we can add it in the Actions menu for every row
- we can add it in the header of the details page
... and we could do both, which seems to me as the best option. Let me know what you are thinking.
katrin-freihofner
on 23 Sep 2019
@katrin-freihofner Thinking about it more, that link should only go near missing data. I.E. Anywhere we display a missing location we should say NA (?) with the ? going to the docs.
If we put it in actions that could confuse due to the fact that it's not a real action, just a link to the docs page.
WDYT?
andrewvc
on 23 Sep 2019
@andrewvc sounds good. The link text should definitely describe where this is leading to. Therefore, I would prefer Add location.
katrin-freihofner
on 24 Sep 2019
@katrin-freihofner besides add location button, where we will show location if it's added?
shahzad31
on 11 Oct 2019
@shahzad31
katrin-freihofner
on 14 Oct 2019
Summarizing a discussion I had with @shahzad31 here.
So, going over how 'missing' locations might actually be handled we considered a few options. Where we landed was to show the missing locations as unnamed location 1, unnamed location 2 etc., and add a new widget (maybe a callout in yellow) underneath the location list. The text there would be
1 / 2 heartbeat instances do not have a location defined. [Add a location](link-to-docs) to your heartbeat configuration.
The thinking here it would be awkward to just show 'Add location' in a hybrid situation without two heartbeats, one with, and one without, a location. The rendered text as proposed prior to this comment would be New York, Add Location with Add Location indicating that something was missing a location.
While the proposed approach here is visually bulkier, that's a good thing. We want people to set the setting, and making it a little ugly is a fine way of getting there.
andrewvc
on 21 Oct 2019
@andrewvc @justinkambic what do you guys think about not able to see any dns information in new design?
I mean now it's mostly location oriented. Does it make sense to show which dns is up or down?
I am not sure if this point has been discussed in redesign phase.
shahzad31
on 12 Nov 2019
Related issues
bradvido
路
3Comments
timroes
路
3Comments
mark54g
路
3Comments
celesteking
路
3Comments
MaartenUreel
路
3Comments
Most helpful comment
Summarizing a discussion I had with @shahzad31 here.
So, going over how 'missing' locations might actually be handled we considered a few options. Where we landed was to show the missing locations as
unnamed location 1,unnamed location 2etc., and add a new widget (maybe a callout in yellow) underneath the location list. The text there would be1 / 2 heartbeat instances do not have a location defined. [Add a location](link-to-docs) to your heartbeat configuration.The thinking here it would be awkward to just show 'Add location' in a hybrid situation without two heartbeats, one with, and one without, a location. The rendered text as proposed prior to this comment would be
New York, Add LocationwithAdd Locationindicating that something was missing a location.While the proposed approach here is visually bulkier, that's a good thing. We want people to set the setting, and making it a little ugly is a fine way of getting there.