Kibana: `vscode-jsonrpc` included in the browser, but not transpiled for IE

[spalger]

At some point vscode-jsonrpc was included in the front-end code which causes https://github.com/elastic/kibana/issues/40674 because, at least, vscode-jsonrpc/lib/messages includes class syntax which is not supported in IE.

This is known to be the case in 7.3 and newer.

Is there a chance that we can install a transpiled version of this module? Maybe there's a slightly older version we can use? Should we write our own reusable error classes rather than trying to reuse them from the jsonrpc module? Maybe the source module would be open to transpiling to support the ancient Microsoft browser that haunts us all?

[elasticmachine]

Pinging @elastic/code

[mw-ding]

this is the only place where vscode-jsonrpc is referenced in frontend (i.e. .../code/public/...). we should just remove it. @spacedragon

[spalger]

There are several references in common code, is that going to be an issue too?

[mw-ding]

There are several references in common code, is that going to be an issue too?

ah, yes. still, not too many there. writing our own reusable error classes should be pretty quick. should be a quick fix.

[mw-ding]

@spalger I think one question here is that the code has been there for a while and went through the 7.2 release. Then how come the previous QA process did not find this problem?

[spalger]

Yeah, best I know it wasn't a problem in 7.2, so there must be something new in 7.3 that's causing this code to be pulled in, or maybe we updated vscode-jsonrpc since 7.2?

[mw-ding]

Yeah, best I know it wasn't a problem in 7.2, so there must be something new in 7.3 that's causing this code to be pulled in, or maybe we updated vscode-jsonrpc since 7.2?

yes, will check on that. cc: @zfy0701

[zfy0701]

yes, we've upgrade the json dependency after 7.2. Yulong has submitted the fix