Kibana: Dark theme not applied in Kibana correctly

[timroes]

This is a meta issue tracking all the places in which the new global dark theme isn't correctly applied yet:

• [x] Discover Popular fields
  
• [x] Discover Time range selector above histogram
  
• [x] Discover Index selector when opened
  
• [x] Filter bar select field in filter bar (will be gone via Filter Bar EUI migration)
• [x] Visualize Editor tabs
  
• [x] Visualize Text fields in editor
  
• [x] Timelion Legend background
  
• [x] Timelion Options panel
  
• [x] Query Bar Autocompletion in Query Bar (#29684)
  
• [x] Visualize Y Axis line color look bad in dark theme (#12740)
• [x] Dev Tools Console Error
  
• ~[ ] Region Map legend background too transparent on dark theme~ Created #31731
  

[elasticmachine]

Pinging @elastic/kibana-app

[elasticmachine]

Pinging @elastic/kibana-design

[JacobBrandt]

Search auto complete also doesn't have dark theme applied

[timroes]

Thanks for the hint. Added it to the above list.

[alexfrancoeur]

https://github.com/elastic/kibana/issues/29746 TSVB labels on gauge

[timroes]

@ryankeairns Could you please open a separate issue for the Dev Tools, and link it to the :Elasticsearch UI team, since the dev tolls are not part of the Kibana team.

[snide]

Since I don't see most of this being fixed by anyone outside the design team, I'd rather we just keep one issue so we don't need to jump from issue to issue for reporting. We can jus drop the app team label to tie it to us.

[cchaos]

This open PR will take care of a lot if not (almost) the rest of the vis dark mode issues: https://github.com/elastic/kibana/pull/30478 if someone would like to review.

[kerber]

Does anyone foresee any fix for these issues on 6.X? For those of us relying heavily on dark mode for displays, it is a rather apparent. In this case, is it advisable to skip 6 entirely and wait for 7?

[snide]

I answered this in your other thread

Kibana 7 introduces dark mode across all of Kibana. As such it involved us spending a lot more time on the dark modes in Kibana. 6.7 has _some_ minor fixes in it against dark mode dashboards (which is all that Kibana 6.x supports), but not the breadth that is covered here, which is mostly tracking changes against master.

If dark mode is important to you 7 will be the best experience. If there is a specific issue in 6 that is bothering you, I'd make a ticket and it's probably we can add a bugfix for you against 6.7 or 6.6.x. Feel free to tag me on it when you make it.

[kerber]

Apologies. As the other thread was on a specific pull request, I incorrectly assumed that your answer was only referring to that pull and not in general. I didn't want to litter its comments with more general questions, so this seemed more appropriate for follow-ups. Thank you for clarifying.

I'll continue with my testing of 6.X and determine how badly the issues are affecting us before bothering with an additional ticket. I am attempting to keep us up to date with the newest stable release, so I'll certainly be looking at 7 when it drops.

[snide]

@kerber No worries. I'm pretty sure we can backport a fix for you pretty quickly if you point out what you're seeing, just want to make sure we're fixing the right stuff. Most of the issues covered in these other issues were for more broad 7 stuff that likely doesn't apply.

[cchaos]

Another item was added.... but I don't think the map legend is specific to dark mode as it's the same opacity in light mode. I'll create a separate ticket.