Kibana: Term aggregation size 0 - Breaking Change

[gmoskovicz]

Kibana version: Kibana 5.0 Alpha 5

Elasticsearch version: Elasticsearch 5.0 Alpha 5

Server OS version: Any

Browser version: Any

Browser OS version: Any

Original install method (e.g. download page, yum, from source, etc.): Any

Describe the feature:

From an elasticsearch braking change, now we don't support size:0 anymore in a term aggregation: https://www.elastic.co/guide/en/elasticsearch/reference/5.0/breaking_50_aggregations_changes.html#_literal_size_0_literal_on_terms_significant_terms_and_geohash_grid_aggregations.

You can still set the Size of the aggregations to 0 in the Terms Visualization:

Hence, you will get an error like the following:

[2016-09-19 09:46:33,993][DEBUG][action.search            ] [lSCmLXk] All shards failed for phase: [query]
RemoteTransportException[[lSCmLXk][127.0.0.1:9300][indices:data/read/search[phase/query]]]; nested: IllegalArgumentException[size must be positive, got 0];
Caused by: java.lang.IllegalArgumentException: size must be positive, got 0

I propose changing the minimum size to 1 instead of 0.

[tylerfontaine]

I propose changing the minimum size to 1 instead of 0.

That will help for newly created visualizations, but that doesn't fix existing visualizations. We should warn that some visualizations will not work until they get updated - more clearly than the stack trace.

[gmoskovicz]

Speaking with @jbudz we said that perhaps adding the visualization name in Kibana, and maybe more information about this issue should help when working on a Dashboard?

@epixa what do you think?

We have two issues here:

1. Main Bug that will be fixed in 5.0
2. Upgrade bug from 2.x.

[gmoskovicz]

Nice

[thomasmodeneis]

Oh another breaking change not documented. :|

[cjcenizal]

@thomasmodeneis Can you explain how you see this as a breaking change? We changed a UI input element to prevent the user from being able to enter bad data. Are there use cases where this causes something to break for you?

[thomasmodeneis]

This is not only related to kibana, my coment is that Elasticsearch 5.0 introduced this breaking change size must be positive, got 0 (and many more) but never mind to explain on the official documentation: https://www.elastic.co/guide/en/elasticsearch/reference/5.0/breaking-changes.html so we end finding out in tickets like this clues on how to deal with it.

Cheers.

[hakanai]

They did eventually document it:

https://www.elastic.co/guide/en/elasticsearch/reference/5.0/breaking_50_aggregations_changes.html

What they failed to document was the replacement, if you actually do want all results back.

[gmoskovicz]

@thomasmodeneis @trejkaz

There are two ways to replace the ones that aren't working after an upgrade:

1. Go 1 by 1 inside the Objects in Kibana, and modify the state of the Visualization in order to fix this parameter.
2. Export the objects to JSON, modify the wrong ones automatically or with a script (be careful), and then re-import the visualizations.