Kiali: Refactor refresh controls in Log tab

Created on 21 Jul 2020  路  5Comments  路  Source: kiali/kiali

The log tabs is missing the consistency across other tabs with the refresh controls:

image

backlog bug teasaturn

All 5 comments

Ah ok @lucasponce +1

It's not only for consistency, with a PR in the way:
https://github.com/kiali/kiali-ui/pull/1833#issue-439918927
we need to refactor a little bit how the refresh in logs work because it will change the containers after an update operation.

@mtho11, if you prepare the the refactoring I can work in the refresh way, but I didn't want to change your code as you are actively working on this tab.

I added this to the backlog and unassigned @mtho11 for now. I think this can be done outside of his current work on the logs window and as it depends on the 3scale work/refactor it likely needs to wait until that work is merged. I will add a wait label for now. We can assign as makes sense when that label is removed.

I removed the "waiting eng" and added a "bug".
As it creates a consistency problem in the details pages being the only tab that have different location of these controls.

I don't have bandwidth to work on this week, but it's something we need to fix.

Assigning @mtho11 , Mike, prio this one as a bug, let's see if we can get it fixed up for 1.22.1 (Aug 7). Ask @lucasponce for details, if necessary.

Was this page helpful?
0 / 5 - 0 ratings