Kiali: Missing Sidecar Icons in List/Detail pages is strange looking

Created on 14 Nov 2019  路  5Comments  路  Source: kiali/kiali

General remarks
It looks like the Missing sidecar icons in the listing and detail pages are chopped (missing some pixels on the left). This is minor visual issue.

Kiali_Console

Kiali_Console

Expected Behaviour
For comparison, see the Missing sidecar Icons in Service graph:
Kiali_Console

bug

All 5 comments

@lucasponce can this issue be put in backlog of sprint 42?

@hhovsepy I'm reviewing this one.
You mean that in master (as there were some refactoring) what is broken is the "missin sidecar" icon on lists, isn't it ?

Ok, this issue was lost in the sea of the Github notifications.
It seems there is a CSS bug:
image

That is cutting the icon on the left, or at least it's what I understand.

@lucasponce @mtho11 I think this is just the way the icon is. We use the Blueprint icon (I have no idea why, I don't like this icon for missing sidecar) but this probably is just the way it looks at a certain resolution. https://www.patternfly.org/v4/guidelines/icons/

In my opinion we should use this issue to change the icon or otherwise just close it.

@lucasponce @mtho11 Closing as won't fix. If we ever want to change the icon I'm +1, but more than likely we'll leave it as is for consistency.

Was this page helpful?
0 / 5 - 0 ratings