Karate: Arguments to karate.call pollute namespace of subsequent calls

[kkris]

I think I found a regression from 0.9.2 (compared to 0.9.3.RC2) which was probably introduced by the fix in #722. It seems that (maybe only some) calls can pollute the namespace of the subsequent calls. In this case I found, the arguments passed to one karate.call are then also visible in any subsequent karate.call.

I have prepared a reproducing example:
scopebug.zip

Let me know if you need any more info!

[ptrthomas]

@kkris I think I fixed it, can you verify that #722 is not impacted ?

[kkris]

Unfortunately this change reverts #722 to the old behavior.

Could resetting the CURRENT_CONTEXT after the ScriptBridge is destroyed help?

[ptrthomas]

took a look and am giving up for now. the report for this scopebug example looks OK to me with the above fix.

see if you can solve. hint, it is this line that appends the result (which is reported) onto the right "parent" https://github.com/intuit/karate/blob/develop/karate-core/src/main/java/com/intuit/karate/Script.java#L1763

maybe we can add a reportContext variable to the CallContext class which is already a little cluttered

[ptrthomas]

@kkris actually hang on, let me try make this change

[kkris]

Ah, I think I worded my previous reply misleadingly. Your change does fix the bug exhibited by the scopebug example, but regresses the example attached in #728.

[ptrthomas]

@kkris okay can you see if it works fine now ?

[kkris]

Both #728 #722 and #795 are fixed with your change if I change the context as you suggested above:
callContext.reportContext.addCallResult(result) instead of callContext.context.addCallResult(result)

[ptrthomas]

@kkris wow I totally missed the most important part, thanks for catching that ! guess this is fixed now

[kkris]

Yes, perfect!

[ptrthomas]

released 0.9.3