Karate: WebSocketOptions doesn't use the provided "headers" map

Created on 5 Jul 2019  路  3Comments  路  Source: intuit/karate

Based on the following code:

public WebSocketOptions(String url, Map<String, Object> options) { this.uri = URI.create(url); ssl = "wss".equalsIgnoreCase(uri.getScheme()); port = uri.getPort() == -1 ? (ssl ? 443 : 80) : uri.getPort(); if (options != null) { subProtocol = (String) options.get("subProtocol"); Integer temp = (Integer) options.get("maxPayloadSize"); if (temp != null) { maxPayloadSize = temp; } } }

The "headers" map is not used anywhere as opposed to the docs https://github.com/intuit/karate#websocket

bug fixed

Most helpful comment

released 0.9.4

All 3 comments

thanks for catching this, I've just requested a change, do confirm and re-submit the PR

@khanguyen88 never mind, I accepted your pr

released 0.9.4

Was this page helpful?
0 / 5 - 0 ratings

Related issues

bbchristians picture bbchristians  路  4Comments

76creates picture 76creates  路  3Comments

sadiqkassamali picture sadiqkassamali  路  4Comments

ampc picture ampc  路  5Comments

ptrthomas picture ptrthomas  路  5Comments