Exciting stuff! Is the plan to add support for the .NET Framework, .NET Core ... or both?
@connorads lets do both! :)
I wonder how the Dockerfile would differ between them? Would a single Dockerfile be good enough to build all .NET projects for c#?
@jstrachan I reckon that it would probably be better to start with building .NET Core only.
.NET Core is multi-platform by design and therefore has proper Linux support.
https://docs.microsoft.com/en-us/dotnet/standard/choosing-core-framework-server
.NET Core is also what people are predominantly using for containerised microservices development and is what is recommended for use by Microsoft.
https://docs.microsoft.com/en-us/dotnet/standard/microservices-architecture/net-core-net-framework-containers/general-guidance
Microsoft already have a Docker image for building ASP.NET Core projects using a Linux container.
https://hub.docker.com/r/microsoft/aspnetcore-build/
I believe that to build .NET framework project for Windows using Docker you would need to use a Windows Container which I'm assuming would be a no-go for Jenkins X, at least for the foreseeable future.
.NET Framework does have support for containers but it's Windows containers only. It's also not the default choice recommended by Microsoft for containerised .NET applications.
https://docs.microsoft.com/en-us/dotnet/standard/microservices-architecture/net-core-net-framework-containers/general-guidance
Microsoft also have a Docker image for building .NET Framework which uses Windows Server 2016 Server Core (Windows container only).
https://hub.docker.com/r/microsoft/dotnet-framework-build/
I think it was a .Net core quickstart we had in fabric8 https://github.com/fabric8-quickstarts/dotnet-example and we used an onbuild image https://github.com/fabric8io/fabric8-jenkinsfile-library/blob/master/dotnet/ReleaseStageApproveAndPromote/Jenkinsfile#L16 should be fairly easy to create a build pack for Jenkins X
Nice one @rawlingsj, I agree it should be relatively easy.
It might be a good idea to make it clear that this issue is for adding .NET Core support and update the Jenkins X roadmap accordingly.
btw I just added this quickstart https://github.com/jenkins-x-quickstarts/aspnet-app
wonder if we need a 'just .NET Core' one too?
Can we close this issue?
.NET Core seems to be working with Jenkins-X.
I used the Jenkins-X ASP.NET Core Quickstart @jstrachan added with jx & GCP and it worked well 馃憣
I reckon you only need to keep this issue open if you plan to get jx to work for .NET Framework which I imagine jx doesn't plan to support as it is primarily Windows only.
Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Provide feedback via https://jenkins-x.io/community.
/lifecycle stale
Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.
Provide feedback via https://jenkins-x.io/community.
/lifecycle rotten
Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.
Provide feedback via https://jenkins-x.io/community.
/close
@jenkins-x-bot: Closing this issue.
In response to this:
Rotten issues close after 30d of inactivity.
Reopen the issue with/reopen.
Mark the issue as fresh with/remove-lifecycle rotten.
Provide feedback via https://jenkins-x.io/community.
/close
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Most helpful comment
Nice one @rawlingsj, I agree it should be relatively easy.
It might be a good idea to make it clear that this issue is for adding .NET Core support and update the Jenkins X roadmap accordingly.