jx import fails on hooks not found

[tdcox]

Using:
NAME VERSION
jx 1.0.127
Jenkins X 0.0.283
Kubernetes v1.7.12-gke.1
Helm Client v2.8.1+g6af75a8
Helm Server v2.8.1+g6af75a8
Git git version 2.14.3 (Apple Git-98)

Actions:
jx import on project that already exists in GitHub repo.

Import fails with:

Created Jenkins Project: http://jenkins.jx.dvs.je/job/DVSJersey/job/customs-mock/
error: GET https://api.github.com/repos/DVSJersey/customs-mock/hooks: 404 Not Found []

Is this perhaps due to the project already being manually placed on GitHub? Expecting hooks that would have been installed by the import process otherwise?

[jstrachan]

lemme make the code just log a warning if we get an error querying wehooks

[tdcox]

Using:
NAME VERSION
jx 1.0.131
Jenkins X 0.0.283
Kubernetes v1.7.12-gke.1
Helm Client v2.8.1+g6af75a8
Helm Server v2.8.1+g6af75a8
Git git version 2.14.3 (Apple Git-98)

Is this still an error, or just a warning?

➜ jx import
--> Ready to sail
[master e6d5112] Draft create
 10 files changed, 193 insertions(+)
 create mode 100755 charts/vrs-service/.helmignore
 create mode 100644 charts/vrs-service/Chart.yaml
 create mode 100755 charts/vrs-service/Makefile
 create mode 100755 charts/vrs-service/README.md
 create mode 100755 charts/vrs-service/templates/NOTES.txt
 create mode 100755 charts/vrs-service/templates/_helpers.tpl
 create mode 100755 charts/vrs-service/templates/deployment.yaml
 create mode 100755 charts/vrs-service/templates/service.yaml
 create mode 100755 charts/vrs-service/values.yaml
 create mode 100644 draft.toml
[master 6f058c8] Added Release Dockerfile pipeline
 1 file changed, 7 insertions(+)
 create mode 100755 Dockerfile.release
[master ea3acdf] Added default Jenkinsfile pipeline
 1 file changed, 101 insertions(+)
 create mode 100755 Jenkinsfile
Counting objects: 21, done.
Delta compression using up to 32 threads.
Compressing objects: 100% (19/19), done.
Writing objects: 100% (21/21), 4.88 KiB | 2.44 MiB/s, done.
Total 21 (delta 3), reused 8 (delta 0)
remote: Resolving deltas: 100% (3/3), completed with 1 local object.
To https://github.com/DVSJersey/vrs-service
   edd388b..ea3acdf  HEAD -> master
? Do you wish to use dvsbot as the user name to register webhook Yes
Created Jenkins Project: http://jenkins.jx.dvs.je/job/DVSJersey/job/vrs-service/
Error querying webhooks on DVSJersey/vrs-service: GET https://api.github.com/repos/DVSJersey/vrs-service/hooks: 404 Not Found []
Creating github webhook for DVSJersey/vrs-service for url http://jenkins.jx.dvs.je/github-webhook/
error: POST https://api.github.com/repos/DVSJersey/vrs-service/hooks: 404 Not Found []

[tdcox]

This was due to using a github account to jx import that was part of the organisation, but not explicitly set up as a contributor to some repos that were created by another dev. Setting team access on the repos where all accounts are in the team solves it, but it's a manual step that has to be done each time.