In function enemy_army_calculate_roman_influence:
Shouldn't the code be MAX_FORMATIONS instead of MAX_LEGIONS on line 97? Or is this an original bug?
Note that the same bug is present when using the L hotkey to cycle the legions.
So this is and isn't a bug. The game always assigns our legions to the first six slots of available formations. So there's really no difference between using MAX_LEGIONS or MAX_FORMATIONS, as the last formation index will always be inside the MAX_LEGIONS.
This could however be a problem if more legions are added, specifically more than 9 legions (as it seems the herds get assigned to formation 10). That shouldn't happen in Julius but might be a problem for Augustus, so for code consistency I'd say we should fix this.
Most helpful comment
So this is and isn't a bug. The game always assigns our legions to the first six slots of available formations. So there's really no difference between using
MAX_LEGIONSorMAX_FORMATIONS, as the last formation index will always be inside theMAX_LEGIONS.This could however be a problem if more legions are added, specifically more than 9 legions (as it seems the herds get assigned to formation 10). That shouldn't happen in Julius but might be a problem for Augustus, so for code consistency I'd say we should fix this.